Repository navigation
[TST-E4] test: the six earlier declared-error slices define each door once per area - #464
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
What does this PR do?
It moves the six earlier declared-error slices to the shared-door shape #463 introduced. In Worktrees, Config, Credentials, Debug, Experimental and Forms, each distinct
DeclaredErrorDoorbecomes oneprivate static readonly DeclaredErrorDoor <Member>Doorfield declared beforeRows(), followingFileSystem/FileSystemDeclaredErrors.cs. Every case of that door references the field._tag, CLR type and JSON pointer, in the same order. Every door keeps itsnameoflabel, operationId, HTTP method, path and lambda unchanged inside its field; only the indentation moves. Merged doors were identical in all five parts.DeclaredErrorTests.cs, the records, the FileSystem and Integrations slices, the contract classes and the clone baseline are untouched.Net line delta: +90 / −98 = −8 in test code.
🔄 Type of Change
🎯 Protocol & API Surface
external/,spec/orsrc/was touched🧪 Testing
Test mapping (mechanical:
e4_test_map.pyovergit diff 21bb0fb8 52d38304)Unmapped: 0
tests/OpenCode.Sdk.Tests/Config/ConfigDeclaredErrors.cstests/OpenCode.Sdk.Tests/Credentials/CredentialsDeclaredErrors.cstests/OpenCode.Sdk.Tests/Debug/DebugDeclaredErrors.cstests/OpenCode.Sdk.Tests/Experimental/ExperimentalDeclaredErrors.cstests/OpenCode.Sdk.Tests/Forms/FormsDeclaredErrors.cstests/OpenCode.Sdk.Tests/Worktrees/WorktreesDeclaredErrors.csNo test method is removed or added, so the table has no rows.
Executed cases: identical
The full
/*/*/DeclaredErrorTests/*listing on net10.0 is the same 78 display names, in the same order, at base and at head. The ordered-list SHA-256 matches:83EE7D3D…870D0. A case's display name comes from its case id and the door'sMemberName, and neither changes.Equivalence mutants: not applicable. No method is removed and no assertion moves. The per-position byte comparison below proves that the data the spines run on is unchanged.
Review
Clones
verify-clonesat head: tests 586 clones, 4.99%, 0 new, the same as master. The total and the tests % do not rise, and no baseline change is needed.Local check (Windows, at 247afa3, tree-identical to the worker's 52d38304)
dotnet build -c Release: 0 errorsdotnet format whitespace/style --verify-no-changes: clean[Category!=NativeAot]: 2086 / 2086 passed[(Category!=ServiceElection)&(Category!=NativeAot)]: net10.0 2862 / 2862, net472 2867 / 2867 passedNeed help on this PR? Tag
@codesmith-botwith what you need.