Repository navigation
[RT-E6] test: the door refusals and the contender exit head are pinned before RT-E6 rewrites them - #461
Merged
Conversation
… RT-E6 rewrites them
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR adds test-only characterization for the last two RT-E6 targets (C5 and C6). It pins the public doors' command-validation messages and the background-service contender's exit-message head before RT-E6 rewrites them. In RT-E6, step 2 merges
SnapshotCommandwithEnsureRequest.CopyCommand, and step 4 rewritesStderrTail. Product code does not change.The change
C6:
OpenCodeServerContractTestsThe two existing door tests stay as they are; they pin only the exception type. Two
[Arguments]tests sit beside them, one per door:StartAsync_Should_Name_The_Refused_Command_And_Its_OptionsEnsureAsync_Should_Name_The_Refused_Command_And_Its_OptionsFor the empty command and for the blank entry, each test pins the exact
ArgumentException.Messageand pinsParamName == "options".optionsis the public parameter of both doors.The four texts:
OpenCodeServerEnsureOptions.prefix.Every case refuses before anything spawns.
Both tests use one helper,
AssertOptionsRefusalAsync(door, text), which holds the sharedThrows,MessageandParamNameassertions. The first local check found the two test bodies to be a clone of each other.The expected message is written out per runtime:
text (Parameter 'options')on .NET, andtext, a newline, thenParameter name: optionson .NET Framework. The characterization spec suggested building it withnew ArgumentException(text, "options"), but CA2208 rejects that form in a test method. Hiding the name from the analyzer would be a dodge, so the test states the BCL's format instead.C5:
ServiceContenderSpawnerTestsOne assertion is added to
TryGetFailure_Should_Report_A_Nonzero_Exit_With_The_Stderr_Tail, and its existing assertions are unchanged.The message must start with "The background service contender (pid ) exited with code 2." followed by
"\n". Exit codes keep their spelling under U3-16, so the pin is stable. Only the head and the"\n"join are new.Proof
Each mutant is a compiling product edit unless noted, run on net10.0 and on net472. The two runtimes gave identical results, and the edits were restored afterwards:
srcis clean.StartAsyncrow goes red. The two existing type-only door tests stay green, as does everything else.ParamName:nameof(options)→"command"EnsureAsyncrow goes red. Everything else stays green.ParamName:CopyCommand(..., "command")EnsureAsyncrow goes red. Everything else stays green."\n"→" "TryGetFailuregoes red at the newStartsWith. Its failure message shows that the two existingContainschecks still hold.Checks:
6015a2e1(master282a4c1e): all 8 steps, and 10,563 tests with 0 failed. The first run failedverify-cloneson the duplicated test bodies, before the helper was extracted.Process note
The Sol worker for this task stopped twice before editing anything. Both stops were justified by the coordinator's prompt. The first time, "do not edit
src" contradicted the per-assertion product-mutant proof. The second time, the exception added for that proof listed the text lines but not theParamNamesites. The coordinator then wrote the tests by hand.Need help on this PR? Tag
@codesmith-botwith what you need.