Skip to content

test: one config test owns the shared server's configuration (#440) #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Blind-Striker merged 1 commit into from
Oct 17, 2026
Merged

test: one config test owns the shared server's configuration (#440) #443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 24 additions & 51 deletions tests/OpenCode.Sdk.Tests/Config/ConfigClientLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,61 +40,19 @@ public async Task GetShellsAsync_Should_Report_Acceptable_Host_Shells(Cancellati
" acceptable=" + Number(response.Shells.Count(static shell => shell.Acceptable)));
}

[Test]
[Timeout(60_000)]
public async Task UpdateConfigAsync_Should_Persist_And_Clear_The_Shell(CancellationToken cancellationToken)
{
using var client = server.CreateClient();
var shells = await client.Config.GetShellsAsync(cancellationToken: cancellationToken);
var shell = shells.Shells.First(static candidate => candidate.Acceptable).Path;
var cleanup = new OwnedCleanup(TimeSpan.FromSeconds(10));
var cleared = false;
Exception? failure = null;
cleanup.Own("clear isolated shell config", async token =>
{
if (!cleared)
{
_ = await client.Experimental.UpdateConfigAsync(
new ExperimentalConfigUpdateRequest { Shell = null, }, cancellationToken: token);
}
});
try
{
var set = await client.Experimental.UpdateConfigAsync(
new ExperimentalConfigUpdateRequest { Shell = shell, }, cancellationToken: cancellationToken);
await Assert.That(set.Status).IsEqualTo(204);
var jsonOptions = new JsonDocumentOptions
{
AllowTrailingCommas = true,
CommentHandling = JsonCommentHandling.Skip,
};
using var afterSet = JsonDocument.Parse(await server.ReadGlobalConfigAsync(cancellationToken), jsonOptions);
await Assert.That(afterSet.RootElement.GetProperty("shell").GetString()).IsEqualTo(shell);

var clear = await client.Experimental.UpdateConfigAsync(
new ExperimentalConfigUpdateRequest { Shell = null, }, cancellationToken: cancellationToken);
await Assert.That(clear.Status).IsEqualTo(204);
using var afterClear = JsonDocument.Parse(await server.ReadGlobalConfigAsync(cancellationToken), jsonOptions);
await Assert.That(afterClear.RootElement.TryGetProperty("shell", out _)).IsFalse();
cleared = true;
}
catch (Exception exception)
{
failure = exception;
}

await cleanup.CompleteAsync(failure);
}

/// <summary>
/// <c>config.get</c> answers the location's loaded configuration, and <c>experimental.config.update</c>
/// writes the global file and only requests a reload (debounced, asynchronous) that publishes
/// <c>config.updated</c> once the loaded entries change. So the read-back waits for that event,
/// never for a clock, and reads again after each one until the write shows.
/// <c>experimental.config.update</c> writes the global file and only requests a reload
/// (debounced, asynchronous) that publishes <c>config.updated</c> once the loaded entries
/// change, and <c>config.get</c> answers the loaded configuration. So each write is checked in
/// the file at once, and its read-back waits for that event, never for a clock, reading again
/// after each one until the write shows. This is the only test that writes the shared server's
/// configuration, and it ends only once the loaded state is back at its start: a write that
/// returns the file to the loaded state inside the debounce publishes nothing, so a second
/// writer that left a reload pending would starve the next one's event.
/// </summary>
[Test]
[Timeout(180_000)]
public async Task GetConfigAsync_Should_Read_Back_The_Shell_UpdateConfig_Wrote(CancellationToken cancellationToken)
public async Task UpdateConfigAsync_Should_Persist_The_Shell_GetConfigAsync_Reads_Back_And_Clear_It(CancellationToken cancellationToken)
{
using var client = server.CreateClient();
var shells = await client.Config.GetShellsAsync(cancellationToken: cancellationToken);
Expand All @@ -120,11 +78,26 @@ public async Task GetConfigAsync_Should_Read_Back_The_Shell_UpdateConfig_Wrote(C
var set = await client.Experimental.UpdateConfigAsync(
new ExperimentalConfigUpdateRequest { Shell = shell, }, cancellationToken: cancellationToken);
await Assert.That(set.Status).IsEqualTo(204);
var jsonOptions = new JsonDocumentOptions
{
AllowTrailingCommas = true,
CommentHandling = JsonCommentHandling.Skip,
};
using (var afterSet = JsonDocument.Parse(await server.ReadGlobalConfigAsync(cancellationToken), jsonOptions))
{
await Assert.That(afterSet.RootElement.GetProperty("shell").GetString()).IsEqualTo(shell);
}

var reloaded = await WaitForShellsAsync(client, probe, after: null, shells => shells.Contains(shell, StringComparer.Ordinal), "the written shell", cancellationToken);

var clear = await client.Experimental.UpdateConfigAsync(
new ExperimentalConfigUpdateRequest { Shell = null, }, cancellationToken: cancellationToken);
await Assert.That(clear.Status).IsEqualTo(204);
using (var afterClear = JsonDocument.Parse(await server.ReadGlobalConfigAsync(cancellationToken), jsonOptions))
{
await Assert.That(afterClear.RootElement.TryGetProperty("shell", out _)).IsFalse();
}

_ = await WaitForShellsAsync(client, probe, reloaded, shells => !shells.Contains(shell, StringComparer.Ordinal), "the cleared shell", cancellationToken);
cleared = true;
}
Expand Down
2 changes: 0 additions & 2 deletions tools/jscpd/tests.baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,6 @@
"411bf938cdbb8b64": 1,
"411f04f073e9ad3f": 1,
"4192fdb04dccceeb": 1,
"41ff4bb4c970a18a": 1,
"4202e901bcb4f8ba": 1,
"42e82776f30ff817": 1,
"4372939ffb05b447": 1,
Expand Down Expand Up @@ -523,7 +522,6 @@
"c59efd159d199356": 1,
"c661cc78e1086df2": 1,
"c6cce4bd6bf12d59": 1,
"c96ee9924b3f4ea7": 1,
"c99b81e4ed3d76fb": 1,
"c99b9aa8b9c89f27": 1,
"c9a68b22b15b2c4f": 1,
Expand Down
Loading