Skip to content

test: consolidate the contract-test infrastructure (#34) #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Blind-Striker merged 5 commits into from
Aug 15, 2026
Merged

test: consolidate the contract-test infrastructure (#34) #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f72c5e5
test: share one FixtureLoader/RecordingHttpHandler pair across the SD…
Blind-Striker Aug 15, 2026
1f08ae3
test: centralize the contract-test scaffold and wire bodies
Blind-Striker Aug 15, 2026
5e22427
test: observe the object-envelope null-datum refusal
Blind-Striker Aug 15, 2026
6b0d916
docs(roadmap): record the PR #26 merge and the #34 consolidation landing
Blind-Striker Aug 15, 2026
ddccbe1
test: close the review's consolidation misses
Blind-Striker Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions docs/ROADMAP.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,12 @@ route onto the transport spine, conflicting BaseAddress refuses, handle guards m
route guards, carrier payload guards, count-guard identity, the Pagination shadow wall)
for 932 green tests, and every surviving finding lives milestone-anchored with an explicit
trigger — #31 (M2, DI lifetime shape, decision-first), #32 (M3, EscapeDataString TFM
policy), #33 (M3, carrier hand-construction semantics, rides #23), #34 (M2, contract-test
consolidation), plus the #27 and #23 enrichments. Merge is awaiting the maintainer's word;
further breadth batches follow merge.
policy), #33 (M3, carrier hand-construction semantics, rides #23), plus the #27 and #23
enrichments. PR #26 is merged. The #34 contract-test consolidation landed as its own
follow-up PR: one shared contract scaffold (`ContractScenario`, `WireBodyData`), a single
`FixtureLoader`/`RecordingHttpHandler` pair compiled from `tests/Shared` into both the SDK
and Extensions test projects, and the previously unobserved object-envelope
`{"data":null}` refusal pinned by test. Further breadth batches follow.

## Milestones

Expand Down
5 changes: 5 additions & 0 deletions tests/OpenCode.Sdk.Extensions.Tests/OpenCode.Sdk.Extensions.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@
<ProjectReference Include="../../src/OpenCode.Sdk.Extensions/OpenCode.Sdk.Extensions.csproj"/>
</ItemGroup>

<!-- Cross-project test support compiles into each consuming test project as shared source. -->
<ItemGroup>
<Compile Include="../Shared/**/*.cs" LinkBase="Shared" />
</ItemGroup>

<!-- .NET Framework ships HttpClient in this framework assembly; no NuGet HTTP stack is added. -->
<ItemGroup Condition="'$(TargetFramework)' == 'net472'">
<Reference Include="System.Net.Http" />
Expand Down
5 changes: 3 additions & 2 deletions tests/OpenCode.Sdk.Extensions.Tests/OpenCodeServiceCollectionExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.DependencyInjection;
using OpenCode.Sdk.Extensions.Tests.Support;
using OpenCode.Sdk.TestSupport;

namespace OpenCode.Sdk.Extensions.Tests;

Expand All @@ -23,7 +24,7 @@ public async Task AddOpenCode_Should_Resolve_The_Client_Through_The_Factory_Pipe
var response = await provider.GetRequiredService<OpenCodeClient>().GetHealthAsync();

await Assert.That(response.Health.Healthy).IsTrue();
await Assert.That(handler.RequestUris.Single()).IsEqualTo(new Uri("http://localhost:4096/api/health"));
await Assert.That(handler.Requests.Single().RequestUri).IsEqualTo(new Uri("http://localhost:4096/api/health"));
}

[Test]
Expand Down Expand Up @@ -86,7 +87,7 @@ public async Task AddOpenCode_Should_Bind_The_Configuration_Section_Including_Cr
_ = await provider.GetRequiredService<OpenCodeClient>().GetHealthAsync();

var expected = $"Basic {Convert.ToBase64String(Encoding.UTF8.GetBytes("admin:secret"))}";
await Assert.That(handler.AuthorizationHeaders.Single()).IsEqualTo(expected);
await Assert.That(handler.Requests.Single().Authorization).IsEqualTo(expected);
}

[Test]
Expand Down
30 changes: 0 additions & 30 deletions tests/OpenCode.Sdk.Extensions.Tests/Support/RecordingHttpHandler.cs
View file
Open in desktop

This file was deleted.

5 changes: 5 additions & 0 deletions tests/OpenCode.Sdk.Tests/OpenCode.Sdk.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@
<ProjectReference Include="../../src/OpenCode.Sdk/OpenCode.Sdk.csproj"/>
</ItemGroup>

<!-- Cross-project test support compiles into each consuming test project as shared source. -->
<ItemGroup>
<Compile Include="../Shared/**/*.cs" LinkBase="Shared" />
</ItemGroup>

<!-- .NET Framework ships HttpClient in this framework assembly; no NuGet HTTP stack is added. -->
<ItemGroup Condition="'$(TargetFramework)' == 'net472'">
<Reference Include="System.Net.Http" />
Expand Down
Loading