Skip to content

Tools.Tests refresh helpers sit in Generator/Refresh/Support but Commands uses them too #403

Open

Description

@Blind-Striker

testing-style.md §1 says a helper one slice uses lives in that slice's Support/, and helpers several slices share stay in the test project's root Support/.

In OpenCode.Sdk.Tools.Tests, Generator/Refresh/Support/ holds RefreshScenario, AutocrlfRefreshScenario and FixedSnapshotTimeProvider. They are used by Generator/Refresh/*Tests and also by Commands/RefreshSpecCommandTests.cs. These are code consumers, not comments. By the consumer-reach rule they belong in the root Support/.

This predates TST-E7-3. The placement comes from the snapshot-refresh refactor (02cfb80f). TST-E7-3 inventoried only the root Support/, so it does not move them; the E7-3b review found it.

Fix: move the three files to tests/OpenCode.Sdk.Tools.Tests/Support/. This is moves only, with namespace and using edits. A first check: verify that AutocrlfRefreshScenario and FixedSnapshotTimeProvider are reached from Commands/ (directly or through RefreshScenario) before moving them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions