Skip to content

QueryStringBuilder depends on the Sessions slice #237

Open

Description

@Blind-Striker

What

src/OpenCode.Sdk/Internal/QueryStringBuilder.cs is a shared helper, but it references
SessionParentFilter, a Sessions type. A shared helper that depends on a feature slice inverts the
dependency direction of the vertical-slice layout (#173).

Proposed

Move the parent-filter formatting into the generated Sessions routes, which is a generator change.
It is optional, because no layout slice needs it.

Activity

  1. added this to the 1.1 milestone on Oct 14, 2026
  2. Blind-Striker commented on Oct 15, 2026

    @Blind-Striker
    CollaboratorAuthor

    Location update after the layout slices: QueryStringBuilder now lives in src/OpenCode.Sdk/Internal/Operations/QueryStringBuilder.cs (L3, #289). L3 moved the file and nothing else, so its upward dependency on the Sessions slice (SessionParentFilter) is unchanged, and this issue stays open as recorded.

  3. modified the milestones: 1.1, 1.0 on Oct 18, 2026
  4. modified the milestones: 1.0, 1.1 on Oct 26, 2026
  5. Blind-Striker commented on Oct 26, 2026

    @Blind-Striker
    CollaboratorAuthor

    Moved to milestone 1.1 by the second 1.0 triage (2026-10-26, maintainer-approved): it is internal, additive, tooling or test structure, so it does not block 1.0.0. The issue stays as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions