Skip to content

Ingestion: SpecReader drops reader warnings and opens the file outside the ingestion boundary #181

Open

Description

@Blind-Striker

What

Two defects in tools/OpenCode.Sdk.Tools/Generator/Ingestion/SpecReader.cs:

  1. Warnings are dropped. After the OpenAPI reader returns, only diagnostic.Errors become
    ingestion errors (:48-51). A document the reader warns about proceeds without a trace.
  2. The open escapes the boundary. File.OpenRead (:24) runs before the try block that
    translates reader failures (:31-44). A spec file that exists but cannot be opened (locked, no
    permission) throws a raw filesystem exception instead of a structured ingestion error.

Why in 1.0

These are defects today, not latent walls. The generator's contract is that every input problem
ends as a located ingestion error, and the 1.0 surface is generated through this reader. Both fixes
are small.

Evidence

Done when

Activity

  1. added this to the 1.0 milestone on Oct 14, 2026
  2. modified the milestones: 1.0, 1.1 on Oct 26, 2026
  3. Blind-Striker commented on Oct 26, 2026

    @Blind-Striker
    CollaboratorAuthor

    Moved to milestone 1.1 by the second 1.0 triage (2026-10-26, maintainer-approved): it is internal, additive, tooling or test structure, so it does not block 1.0.0. The issue stays as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions