You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Ingestion: SpecReader drops reader warnings and opens the file outside the ingestion boundary #181
Two defects in tools/OpenCode.Sdk.Tools/Generator/Ingestion/SpecReader.cs:
Warnings are dropped. After the OpenAPI reader returns, only diagnostic.Errors become
ingestion errors (:48-51). A document the reader warns about proceeds without a trace.
The open escapes the boundary.File.OpenRead (:24) runs before the try block that
translates reader failures (:31-44). A spec file that exists but cannot be opened (locked, no
permission) throws a raw filesystem exception instead of a structured ingestion error.
Why in 1.0
These are defects today, not latent walls. The generator's contract is that every input problem
ends as a located ingestion error, and the 1.0 surface is generated through this reader. Both fixes
are small.
Red tests first: a document with a reader warning, and a file that exists but cannot be opened.
Both end in the structured ingestion failure, and cancellation still surfaces as cancellation.
Moved to milestone 1.1 by the second 1.0 triage (2026-10-26, maintainer-approved): it is internal, additive, tooling or test structure, so it does not block 1.0.0. The issue stays as it is.
Activity
Blind-Striker commentedon Oct 26, 2026
Moved to milestone 1.1 by the second 1.0 triage (2026-10-26, maintainer-approved): it is internal, additive, tooling or test structure, so it does not block 1.0.0. The issue stays as it is.