Repository navigation
fix: resolve the imported release signing identity - #102
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the next real signing failure exposed by the no-publish rehearsal: the direct PKCS#12 import did not produce a usable codesign identity. The stored Foundation certificate and private key are present and valid. Match the shared Swift archetype's import sequence instead: extract certificate and key, select the ephemeral keychain, import both, resolve the exact Foundation identity fingerprint, and use that fingerprint for codesign.
The original keychain search list is restored on success and failure, and cleanup now removes both extracted PEM files. Synthetic tests execute the actual workflow setup and cleanup for success, failed import, and missing identity. All three pass, workflow lint passes, and independent review through P2 is clean. The merged-main dry run will verify real Apple signing and notarization. No release or version tag is created.