Repository navigation
Conversation
|
@imlk0 ,您好,您的请求已接收,请耐心等待结果。 |
|
@imlk0 ,您好,未检测到有镜像需要构建,如需重新检测请评论 /start 。 |
test_qemu_boot_persist_second created its overlay in ${WORKDIR} while
referencing the backing output.qcow2 by basename, but the output image
lives in ${WORKDIR}/${test_name}. qemu-img create therefore failed to
open the backing file (error swallowed by >/dev/null), the overlay was
never created, and the first persist boot died with
"Could not open '<overlay>': No such file or directory" - so both
fsck-140 test-convert-persist rows (alinux3 and alinux4) have been red
since the regression coverage landed.
Create the overlay in the same directory as the output image: the
basename backing reference then resolves both at overlay creation time
and inside the QEMU boot container (which mounts that directory as
/diskdir), matching what the original comment intended. Also fail
loudly when qemu-img create fails instead of discarding the error.
Assisted-by: Claude:glm-5.3
Signed-off-by: Kun Lai <laikun@linux.alibaba.com>
imlk0
force-pushed
the
fix-persist-overlay
branch
from
October 9, 2026 02:04
a73895e to
211bc45
Compare
|
@imlk0 ,您好,您的请求已接收,请耐心等待结果。 |
|
@imlk0 ,您好,未检测到有镜像需要构建,如需重新检测请评论 /start 。 |
Collaborator
Author
|
Superseded: master 6ce9c51 landed the same fix (overlay created next to the output image, bare-name backing reference, error-checked qemu-img create) independently. Closing this PR as redundant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since the disk-persist regression coverage landed (d83f85b), the
fsck-140rows oftest-convert-persistfail on both alinux3 and alinux4 with:Root cause
test_qemu_boot_persist_secondcreated the overlay in${WORKDIR}but referenced the backing image by bare basename:The output image actually lives in
${WORKDIR}/${test_name}/output.qcow2, soqemu-img createfailed to open the backing file. The error was swallowed (>/dev/null, no error check), the overlay was never created, and the first boot then failed on the missing overlay. The "relative backing filename resolves inside the container" mechanism the comment describes never actually worked.Fix
Create the overlay in the same directory as the output image; the basename backing reference then resolves both at creation time and inside the QEMU boot container (which mounts that directory as
/diskdir). Also check theqemu-img createresult and fail loudly instead of discarding the error.Verified locally:
Could not open 'output.qcow2'→ overlay not created);ghcr.io/qemus/qemu:7.29with the directory mounted at/diskdir,qemu-img inforesolves the backing to/diskdir/output.qcow2;bash -n+shellcheck -S errorclean.Not addressed here (separate issues)
fsck-141rows fail withINTEGRITY AEAD ERROR— the real issue fde: disk-persist with integrity=true fails first boot when creating persistent dm-snapshot #141, being fixed separately.