Repository navigation
core: overlap diff root discovery with world state - #30286
Merged
Merged
Conversation
anp-oai
marked this pull request as ready for review
June 26, 2026 23:07
Contributor
Author
|
@codex review |
anp-oai
force-pushed
the
codex/overlap-turn-diff-root-discovery
branch
from
June 26, 2026 23:16
2176b46 to
c7b1ae5
Compare
anp-oai
force-pushed
the
codex/overlap-turn-diff-root-discovery
branch
from
June 26, 2026 23:58
e11c710 to
943b9c4
Compare
won-openai
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Remote diff-root discovery is independent of world-state construction, but it ran afterward and added filesystem metadata latency before the first model request. Overlap the independent work so thread-cold turns do not pay those waits serially.
What
record_context_updates_and_set_reference_context_itemandturn_diff_display_rootswithtokio::join!.TurnDiffTracker; no cache or behavior lifecycle changes are introduced.Validation
A synthetic executor-skill benchmark with artificial network delay: thread-cold model-request p50 improved from about 1.79 s to 1.58 s.