Repository navigation
Conversation
Signed-off-by: Vignesh <vickyofficial26@gmail.com>
|
|
panthera-momagdii
left a comment
There was a problem hiding this comment.
Direction is good, but H-CI-1 is not complete yet against the work-package acceptance you shared.
Please close these before approval:
- The new image workflow only runs on
pushtomain/ manual dispatch, so this PR has no hosted Docker build validation. Add a PR build-only path (no GHCR push) so a broken Dockerfile cannot merge green. - After the publish path is proven, record/pin the produced image digest in the manifest.
- Use that same pinned image for contributor development through a devcontainer, and show a contributor can open it and reach a working build.
- Add evidence for the cold pull-request software gate staying within the 10-minute budget.
- The image currently installs
ros-jazzy-rplidar-ros, while the current 2.0 S3 path is moving tosllidar_ros2from the pinned source manifest. Please either document why the legacy package is still intentionally needed in the baseline image or align the image with the current driver path.
Repository-quality and CLA are green, but they do not validate the container build/publish path itself. Re-request review once the hosted image build and H-CI-1 acceptance evidence are present.
panthera-momagdii
left a comment
There was a problem hiding this comment.
Direction is good, but H-CI-1 is not complete yet against the stated acceptance criteria.
Please close these before approval:
- The image workflow only runs on push to
main/ manual dispatch, so this PR has no hosted Docker build validation. Add a pull-request build-only path (no GHCR push) so a broken Dockerfile cannot merge green. - After the publish path is proven, record and pin the produced image digest in the manifest.
- Use the same pinned image for contributor development through a devcontainer and show that a contributor can open it and reach a working build.
- Add evidence that a cold pull-request software gate stays within the 10-minute budget.
- The image currently installs
ros-jazzy-rplidar-ros, while the current 2.0 S3 path is moving tosllidar_ros2from the pinned source manifest. Either document why the legacy package is intentionally kept in the baseline image or align the image with the current driver path.
Repository-quality and CLA are green, but they do not validate the container build/publish path itself. Re-request review once the hosted image build and H-CI-1 acceptance evidence are present.
Signed-off-by: Arumuga Vignesh S R <129583467+wikki26@users.noreply.github.com>
Signed-off-by: Arumuga Vignesh S R <129583467+wikki26@users.noreply.github.com>
a548857 to
d929043
Compare
Signed-off-by: Arumuga Vignesh S R <129583467+wikki26@users.noreply.github.com>
Signed-off-by: Arumuga Vignesh S R <129583467+wikki26@users.noreply.github.com>
Signed-off-by: Arumuga Vignesh S R <129583467+wikki26@users.noreply.github.com>
Signed-off-by: Arumuga Vignesh S R <129583467+wikki26@users.noreply.github.com>
|
I've pushed the latest H-CI-1 updates and wanted to share the validation status against your review feedback. Completed:
Validation:
Still pending:
Could you review the latest changes and let me know if any further adjustments are needed for H-CI-1 acceptance? Thanks! |
panthera-momagdii
left a comment
There was a problem hiding this comment.
Reviewed the current two-file image/workflow change at a1f619307557ad3a0680065127df7e027d47dd83.
Review basis: openAMRobot/.github, branch h-ci-1-baseline-image, head a1f6193, base 539da19. Expected outcome: acknowledge the image-build follow-up and distinguish the evidence now present from the remaining H-CI-1 acceptance work.
The current change addresses the PR-safe build path, immutable ROS base-image pin, and removal of the legacy ros-jazzy-rplidar-ros package from this image. PR events build without logging into or pushing to GHCR; publishing is separated into the intended main/manual-candidate paths. Action references are pinned. The current image-build run passed.
The candidate is also pinned in manifest #13, and platform-sw #57 demonstrates that it can be pulled and build the seven packages. That is useful integration evidence, but #57's subsequent test failure remains open; the successful build does not make its full gate pass.
The remaining H-CI-1 evidence is still:
- a successful run of the automated GHCR publication path, with the resulting digest;
- an actual VS Code devcontainer startup using that pinned image;
- the complete passing cold gate with its measured duration against the agreed under-10-minute target.
Please attach those run/startup records and keep the PR description aligned with the evidence available. The S3 sllidar integration remains a separate follow-up as documented.
No new blocking source finding in this image-build delta. This follow-up acknowledges the progress; the existing H-CI-1 acceptance review remains incomplete until the outstanding evidence is supplied.
ChatGPT-assisted source and hosted-evidence review; no local devcontainer startup or hardware execution.
BotshareAI
left a comment
There was a problem hiding this comment.
Good: digest-pinned base, actions pinned by SHA, a PR build without push, legacy rplidar package removed. Before merge:
Split the jobs: a build job with contents: read for pull_request, and a publish job with packages: write only for push to main or workflow_dispatch.
The publish condition hardcodes refs/heads/h-ci-1-baseline-image. That branch disappears after merge. Allow dispatch from main only.
Add ros-jazzy-twist-mux (command arbitration, ui #31). Remove ros-jazzy-camera-ros unless a package depends on it; the base camera is the Gemini 336L on the Orbbec driver.
Keep rmw_cyclonedds_cpp as default; it will be recorded as the project RMW in the register.
Provenance: the digest pinned in manifest #13 and platform-sw #57 (sha256:1653d4…) was published from the feature branch. After merge, publish from main, record the run ID and digest, then update #13 and #57 to it.
Devcontainer start-up and the 10-minute cold gate stay with platform-sw #57 and do not block this image PR. The branch is also 8 commits behind main.
Summary
Adds the initial H-CI-1 baseline CI container image for ROS 2 Jazzy and a GitHub Actions workflow for publishing the image to GHCR.
Changes
Validation
Tested locally against
openamr-platform-sw.colcon build --symlink-install: ~1m17sKnown issue
micro_ros_agentdoes not currently have a rosdep definition for Ubuntu Noble. The platform workspace still builds successfully.