Repository navigation
Conversation
…gured The attributes, resource, and span processors are deprecated in the default collector layer build and will be removed in the next release (open-telemetry#2272, open-telemetry#2338). Until now the deprecation was only documented in the README, so users with those processors in their config got no runtime signal. Add a confmap converter that logs a warning through the extension logger for every configured processor of a deprecated type. It runs once at config resolution and does not modify the config.
| for _, name := range found { | ||
| c.logger.Warn("Processor is deprecated in the default collector layer build and will be removed in the next release. "+ | ||
| "Migrate to the transform processor or build a custom layer that includes it. "+ | ||
| "See https://github.com/open-telemetry/opentelemetry-lambda/blob/main/collector/README.md#deprecation-notice", |
Contributor
There was a problem hiding this comment.
Thoughts about pointing this to a tagged release rather than main?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #2272. Prerequisite for #2338.
The
attributes,resource, andspanprocessors are deprecated in the default collector layer build (#2273) and #2338 removes them. So far the deprecation is only documented in the README, so users who still have those processors in their config get no runtime signal before the removal lands.This adds a confmap converter that logs a warning through the extension logger for every configured processor whose type is
attributes,resource, orspan(named instances such asresource/envare matched too). It runs once when the config is resolved, does not touch the config, and adds nothing to the data path.Example log line:
Intended sequence: release this first, then merge #2338 in the following release. #2338 should also delete this converter.