[mawasak]

Contributes to #1429

Changes

Moving code from header file to cc file according to #1429.

For significant contributions please make sure you have completed the following items:

• CHANGELOG.md updated for non-trivial changes
• Unit tests have been added
• Changes in public API reviewed

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: mawasak / name: MariuszW (c0abdc0)

[codecov]

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.77%. Comparing base (cdb5e44) to head (16f09b1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
sdk/src/metrics/view/predicate_factory.cc	90.91%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4688      +/-   ##
==========================================
- Coverage   86.77%   86.77%   -0.00%     
==========================================
  Files         525      525              
  Lines       20747    20742       -5     
==========================================
- Hits        18002    17997       -5     
  Misses       2745     2745              

Files with missing lines	Coverage Δ
sdk/src/metrics/view/predicate_factory.cc	90.91% <90.91%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[marcalff]

@mawasak

Thanks for the contribution.

Please fix format errors in CI, patch below:

diff --git a/sdk/src/metrics/view/predicate_factory.cc b/sdk/src/metrics/view/predicate_factory.cc
index eaf931c..68e26d0 100644
--- a/sdk/src/metrics/view/predicate_factory.cc
+++ b/sdk/src/metrics/view/predicate_factory.cc
@@ -11,7 +11,7 @@ namespace sdk
 namespace metrics
 {
 std::unique_ptr<Predicate> PredicateFactory::GetPredicate(opentelemetry::nostd::string_view pattern,
-                                                 PredicateType type)
+                                                          PredicateType type)
 {
   if (((type == PredicateType::kPattern || type == PredicateType::kWildcard) && pattern == "*") ||
       (type == PredicateType::kExact && pattern == ""))
@@ -32,6 +32,6 @@ std::unique_ptr<Predicate> PredicateFactory::GetPredicate(opentelemetry::nostd::
   }
   return std::unique_ptr<Predicate>(new MatchNothingPattern());
 }
-}
-}
+}  // namespace metrics
+}  // namespace sdk
 OPENTELEMETRY_END_NAMESPACE

Ok to merge after that.

[mawasak]

Hi, format error fixed. Thanks

[marcalff]

LGTM, thanks for the fix.

[dbarker]

Thanks for the cleanup.

[mawasak]

Some iwyu errors yet:-/

[mawasak]

Thanks for merging.