Skip to content

[SDK] Preserve unlimited batch processor shutdown timeout - #4686

Merged
marcalff merged 4 commits into
open-telemetry:mainfrom
Soundcreates:fix/preserve-unlimited-shutdown-timeout
Oct 10, 2026
Merged

marcalff merged 4 commits into
open-telemetry:mainfrom
Soundcreates:fix/preserve-unlimited-shutdown-timeout

Conversation

@Soundcreates

@Soundcreates Soundcreates commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #4681

Changes

  • Preserve the default std::chrono::microseconds::max() timeout when batch span and log record processors shut down their exporters.
  • Preserve the unlimited timeout when MultiLogRecordProcessor shuts down each child processor.
  • Assert that every multi-log child receives the unlimited timeout during default shutdown and that finite shutdowns continue sharing the remaining timeout budget.
  • Add the fix to the unreleased changelog with the PR link.

Testing

  • Built multi_log_record_processor_test, batch_log_record_processor_test, and batch_span_processor_test with CMake and GCC 13.3.
  • multi_log_record_processor_test: 7 passed.
  • batch_log_record_processor_test: 13 passed.
  • batch_span_processor_test: 12 passed.
  • Ran clang-format 18 on the changed C++ file.
  • Ran git diff --check.
  • Ran markdownlint on CHANGELOG.md.
  • Full platform and build-system coverage is left to CI.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed. There is no public API change.

@Soundcreates
Soundcreates requested a review from a team as a code owner October 9, 2026 11:44
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T11:48:27.580242Z b04a6ae PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b04a6ae5ab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread sdk/src/logs/batch_log_record_processor.cc
@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.77%. Comparing base (91bef1e) to head (090e10f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4686      +/-   ##
==========================================
- Coverage   86.83%   86.77%   -0.05%     
==========================================
  Files         525      525              
  Lines       20741    20747       +6     
==========================================
- Hits        18008    18002       -6     
- Misses       2733     2745      +12     
Files with missing lines Coverage Δ
sdk/src/logs/batch_log_record_processor.cc 91.10% <100.00%> (-3.11%) ⬇️
sdk/src/logs/multi_log_record_processor.cc 96.60% <100.00%> (+0.13%) ⬆️
sdk/src/trace/batch_span_processor.cc 88.89% <100.00%> (-3.28%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker dbarker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Please see feedback below.

Comment thread sdk/test/logs/multi_log_record_processor_test.cc
Comment thread CHANGELOG.md Outdated
@Soundcreates

Soundcreates commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor Author

I have addressed all the feedback comments, please review whenever you get a chance.

@dbarker dbarker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@marcalff
marcalff merged commit 1def601 into open-telemetry:main Oct 10, 2026
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Batch processor shutdown reduces the default unlimited timeout to 1 µs

3 participants