Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b04a6ae5ab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4686 +/- ##
==========================================
- Coverage 86.83% 86.77% -0.05%
==========================================
Files 525 525
Lines 20741 20747 +6
==========================================
- Hits 18008 18002 -6
- Misses 2733 2745 +12
🚀 New features to boost your workflow:
|
dbarker
left a comment
There was a problem hiding this comment.
Thanks for the fix. Please see feedback below.
|
I have addressed all the feedback comments, please review whenever you get a chance. |
Fixes #4681
Changes
std::chrono::microseconds::max()timeout when batch span and log record processors shut down their exporters.MultiLogRecordProcessorshuts down each child processor.Testing
multi_log_record_processor_test,batch_log_record_processor_test, andbatch_span_processor_testwith CMake and GCC 13.3.multi_log_record_processor_test: 7 passed.batch_log_record_processor_test: 13 passed.batch_span_processor_test: 12 passed.git diff --check.CHANGELOG.md.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes