Repository navigation
[CODE HEALTH] Fix bugprone-exception-escape in NoopTracer::StartSpan() - #4673
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4673 +/- ##
==========================================
+ Coverage 86.77% 86.78% +0.01%
==========================================
Files 525 525
Lines 20747 20742 -5
==========================================
- Hits 18002 17998 -4
+ Misses 2745 2744 -1
🚀 New features to boost your workflow:
|
dbarker
approved these changes
Oct 8, 2026
dbarker
left a comment
Member
There was a problem hiding this comment.
Thanks. Please consider the optional changes below. Since this class may be instantiated by users and is in the public API, consider adding a breaking change entry to the CHANGELOG.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #2053
Changes
Please provide a brief description of the changes here.
NoopSpan::tracer_, this property is unusedNoopSpanconstructorNoopTracer::noop_span_propertyNoopTracer::noop_span_fromNoopTracer::StartSpan(), fixing the issue.Please note:
api/include/opentelemetry/trace/noop.his located underapi.noop.his not part of the opentelemetry abi, as instrumented applications never see noop objects directly.NoopSpan,NoopTracerandNoopTracerProvideris not a breaking change for instrumentation. It only affects custom exporters.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes