Skip to content

fix(otel)!: bump opentelemetry-semconv-incubating to 1.43.0-alpha - #1844

Open
bye-rez wants to merge 2 commits into
open-feature:mainfrom
bye-rez:fix/otel-semconv-provider-name-bump
Open

bye-rez wants to merge 2 commits into
open-feature:mainfrom
bye-rez:fix/otel-semconv-provider-name-bump

Conversation

@bye-rez

@bye-rez bye-rez commented Aug 26, 2026 •

Copy link
Copy Markdown

This PR

Bumps opentelemetry-semconv-incubating to 1.43.0-alpha in hooks/open-telemetry and updates the one hardcoded test assertion that relied on the old attribute string.

Related Issues

Relates to #1843

Notes

This version renames the feature_flag.provider_name span attribute to feature_flag.provider.name (underscore → dot). Our hook code references the FEATURE_FLAG_PROVIDER_NAME constant rather than a literal, so no source change is needed — only TracesHookTest.java's hardcoded assertion string is updated to match.

Breaking change: consumers reading the feature_flag.provider_name span attribute (dashboards, alerts, queries) will need to update to feature_flag.provider.name.

Follow-up Tasks

A separate PR will adopt newly available semconv attributes (e.g. FEATURE_FLAG_RESULT_VARIANT) — intentionally not bundled here.

How to test

./mvnw --projects hooks/open-telemetry --also-make clean verify

opentelemetry-semconv-incubating 1.43.0-alpha renames the
feature_flag.provider_name span attribute to feature_flag.provider.name.
FEATURE_FLAG_PROVIDER_NAME is referenced by constant in OTelCommons.java,
so no source change is needed there; only the hardcoded assertion string
in TracesHookTest.java is updated to match.

BREAKING CHANGE: consumers reading the feature_flag.provider_name span
attribute (dashboards, alerts, queries) must update to
feature_flag.provider.name.

Signed-off-by: Alex Bairez <bairez14@icloud.com>
@coderabbitai

coderabbitai Bot commented Aug 26, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The OpenTelemetry semantic conventions dependency was upgraded from 1.28.0-alpha to 1.43.0-alpha. The trace hook test now expects the feature_flag.provider.name attribute key.

Changes: OpenTelemetry semantic conventions

Layer / File(s) Summary
Dependency and test alignment
hooks/open-telemetry/pom.xml, hooks/open-telemetry/src/test/.../TracesHookTest.java
The incubating semantic conventions dependency version and the provider-name test attribute key were updated.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: aepfli, chrfwow, justinabrahms

Merge Risk: Minimal · up to 432bf

The change is mergeable; consumers must update queries using the old provider attribute.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title identifies the OpenTelemetry dependency update and its target version.
Description check Passed The description covers the dependency update and the changed test assertion.
Docstring Coverage Passed Docstring coverage is inconclusive: files from earlier reviews still need to be rechecked within the check's analysis limits. Not blocking.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 03a17292-c87d-462c-a348-53a96402b2b8
Commits

Reviewing files that changed from the base of the PR and between bd9d1d2 and 432bf3a.

Files selected for processing: 1

  • hooks/open-telemetry/pom.xml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants