Skip to content

Change generated log files to txt #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martenrebane merged 1 commit into from
Oct 8, 2026
Merged

Change generated log files to txt #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Modules/CommonsLib/Sources/CommonsLib/Constants.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ public struct Constants {
}

public struct File {
public static let LibDigidocLog = "libdigidocpp.log"
public static let AppLog = "ria_digidoc.log"
public static let LibDigidocLog = "libdigidocpp.txt"
public static let AppLog = "ria_digidoc.txt"
public static let LDAPCertsPem = "ldapCerts.pem"
public static let nfcCANKey = "canKey.txt"
}
Expand Down
4 changes: 2 additions & 2 deletions Modules/UtilsLib/Tests/UtilsLibTests/File/DirectoriesTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ struct DirectoriesTests {

#expect(logFilePath != nil)
#expect(trimmedExpectedDirectoryPath == trimmedLogFilePath)
#expect("libdigidocpp.log" == logFilePath?.lastPathComponent)
#expect("libdigidocpp.txt" == logFilePath?.lastPathComponent)
}

@Test
Expand All @@ -249,7 +249,7 @@ struct DirectoriesTests {
let logFilePath = try Directories.getLibdigidocLogFile(from: nil, fileManager: mockFileManager)

#expect(logFilePath != nil)
#expect("libdigidocpp.log" == logFilePath?.lastPathComponent)
#expect("libdigidocpp.txt" == logFilePath?.lastPathComponent)
}

@Test
Expand Down
4 changes: 2 additions & 2 deletions RIADigiDoc/ViewModel/DiagnosticsViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ class DiagnosticsViewModel: DiagnosticsViewModelProtocol, Loggable {

func createDiagnosticsFile(languageSettings: LanguageSettingsProtocol, directory: URL? = nil) async -> URL? {
let diagnosticsText = buildDiagnosticsText(languageSettings: languageSettings)
let diagnosticsFileName = "ria_digidoc_\(self.versionSectionContent)_diagnostics.log"
let diagnosticsFileName = "ria_digidoc_\(self.versionSectionContent)_diagnostics.txt"

return await writeTempFile(fileName: diagnosticsFileName, directory: directory) { fileURL in
try await logCollector.write(diagnosticsText, to: fileURL)
Expand Down Expand Up @@ -363,7 +363,7 @@ class DiagnosticsViewModel: DiagnosticsViewModelProtocol, Loggable {
}

public func createLogFile(directory: URL? = nil) async -> URL? {
let logFileName = "ria_digidoc_\(self.versionSectionContent).log"
let logFileName = "ria_digidoc_\(self.versionSectionContent).txt"

return await writeTempFile(fileName: logFileName, directory: directory) { fileURL in
try await logCollector.writeLogFile(
Expand Down
2 changes: 2 additions & 0 deletions RIADigiDocTests/ViewModel/DiagnosticsViewModelTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,7 @@ final class DiagnosticsViewModelTests {

let fileUrl = try #require(diagnosticsFileUrl)
#expect(!fileUrl.resolvedPath.isEmpty)
#expect(fileUrl.pathExtension == "txt")
#expect(FileManager.default.fileExists(atPath: fileUrl.resolvedPath))
}

Expand Down Expand Up @@ -457,6 +458,7 @@ final class DiagnosticsViewModelTests {

let fileUrl = try #require(logFileUrl)
#expect(!fileUrl.resolvedPath.isEmpty)
#expect(fileUrl.pathExtension == "txt")

let contents = try String(contentsOf: fileUrl, encoding: .utf8)
#expect(contents.contains("===== File: \(CommonsLib.Constants.File.LibDigidocLog) ====="))
Expand Down
Loading