Repository navigation
feat(benchmark): replay recorded report identity decisions - #713
Merged
Merged
Conversation
zzwong
marked this pull request as ready for review
November 6, 2026 22:45
zzwong
commented
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
cr benchmark replay <fixture.json>to inspect recorded report-identity decisions offline. It produces deterministic finding groups or prior-thread associations from a fixture, making those decisions repeatable and reviewable.The v1 fixture contains the original records, caller-selected thread eligibility and recorded pair decisions. Validation and pair hashes reject malformed or stale inputs. Missing, abstained, failed or contradictory cohort decisions leave findings in singleton groups. Prior-thread replay reports associations without choosing thread actions, and the result retains every original finding and thread.
The matching component is used only by the offline benchmark command. An architecture test prevents review-runtime packages from importing it. The change adds no provider calls, profile changes, posting behavior or live review decisions.
Command evidence
Before:
cr 0.10.367at4bd02e8exposescompare,doctor,run,selectandvalidateundercr benchmark, with no replay command.After: the locally built candidate replays the checked-in synthetic fixtures:
complete-cohort.jsonbetaas representative.prior-thread-unresolved.jsonrecorded-error.jsonTwo runs of the complete fixture produced byte-identical stdout. Invalid inherited profile, catalog and credential-backend selections did not affect that replay. This is local synthetic command evidence, not a production or model-quality measurement.
Validation
make tidy,make lintandmake buildpassed; dependencies are unchanged.Type of Change
Checklist
make tidypassesmake lintpassesmake testpasses in CImake buildpassesDocs: Added the fixture contract and command behavior to the benchmark guide and documented the offline import boundary.