Repository navigation
Conversation
zzwong
force-pushed
the
zzwong/INT-870/stable-keychain-reads
branch
from
September 25, 2026 21:47
ae1b70d to
0eeb338
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
macOS Keychain grants can be tied to the hash of an ad-hoc-signed CLI, so replacing a binary can prompt again for each stored credential. The shared credstore currently reads secrets through the caller binary.
Change
Read macOS Keychain generic passwords through the fixed system-signed /usr/bin/security executable, preserving the existing service/account mapping. Keep native Keychain writes, metadata, listing, and deletion; do not pass secrets on command lines or change stored entries. Add hermetic tests and update the shared guidance.
Verification
Release follow-up
Before release, build a consumer against this commit, grant Keychain access once, rebuild it, and verify a second read without a prompt. Coordinate consumer dependency bumps and releases after that check.