Skip to content

fix: batch playlist metadata and show shadow progress - #83

Merged
rianjs merged 1 commit into
mainfrom
fix/playlist-batching-progress
Nov 9, 2026
Merged

rianjs merged 1 commit into
mainfrom
fix/playlist-batching-progress

Conversation

@rianjs

@rianjs rianjs commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator

Large playlist shadows fetched metadata one track at a time, which made them slow and prone to rate limits. Fetch unique tracks in batches of 50 and report actual progress through reading and saving, with a persistent error beside the action. Preserve playlist order, duplicates, and the previous snapshot on failure.

Multi-track Add to library now reuses persisted playlist metadata instead of fetching each track again. Playlist reads request technical metadata and seed complete catalog records only when the response supplies the required fields. Explicit track and album actions use cached genres; normal sync handles missing genre enrichment. Library writes retain their existing batches of 40 and atomic membership/overlay boundaries.

Validation:

  • Live read-only shadow of Soundtracks for Studying: 2,189 tracks in 3.4 seconds; refresh order and temporary save/reload passed.
  • Regression: 85 cached playlist tracks use three save requests and no metadata reads.
  • Rust workspace: 931 passed, 12 ignored; Clippy and formatting passed.
  • Frontend: 221 tests passed, 6 skipped; build and lint passed.
  • Documentation, Tauri ACL, and release-contract checks passed; progress appearance checked in light and dark themes.

@rianjs-bot rianjs-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated PR Review

Reviewed commit: 643af5538546
Profile: codex-rianjs-bot - Posting as: rianjs-bot[bot]

Summary

Reviewer Findings
architecture:seams 0
frontend:view-state 0
rust:implementation-tests 0
tauri:config-ipc 0
security:credential-boundary 0

Reviewer Coverage

Complete coverage details are retained in the local coverage.json artifact.

  • architecture:seams — complete (broad); scope: 17 files; examples: apps/desktop/src-tauri/src/playlist_commands.rs, apps/desktop/src-tauri/src/playlist_state.rs, apps/desktop/src-tauri/src/playlists.rs, apps/desktop/src-tauri/src/provider.rs, apps/desktop/src-tauri/src/shadow_playlists.rs; 12 omitted; body-inspected: 17 files; examples: apps/desktop/src-tauri/src/playlist_commands.rs, apps/desktop/src-tauri/src/playlist_state.rs, apps/desktop/src-tauri/src/playlists.rs, apps/desktop/src-tauri/src/provider.rs, apps/desktop/src-tauri/src/shadow_playlists.rs; 12 omitted; skipped: none; context (not coverage): 4 files; examples: AGENTS.md, ARCHITECTURE.md, docs/architecture/library.md, docs/architecture/persistence.md; constraints: Static architecture review limited to ownership, dependency direction, lifecycle, provider isolation, and abstraction; tests were not run.
  • frontend:view-state — complete (constrained); scope: 1 file; examples: apps/desktop/test/interactions.test.tsx; body-inspected: 1 file; examples: apps/desktop/test/interactions.test.tsx; skipped: none; context (not coverage): 6 files; examples: AGENTS.md, ARCHITECTURE.md, apps/desktop/src/App.tsx, apps/desktop/src/ShadowDiscovery.tsx, apps/desktop/src/spotifyGateway.ts; 1 omitted; constraints: Review limited to the assigned frontend test file and its relevant state-contract context.
  • rust:implementation-tests — complete (broad); scope: 10 files; examples: apps/desktop/src-tauri/src/playlist_commands.rs, apps/desktop/src-tauri/src/playlist_state.rs, apps/desktop/src-tauri/src/playlists.rs, apps/desktop/src-tauri/src/provider.rs, apps/desktop/src-tauri/src/shadow_playlists.rs; 5 omitted; body-inspected: 10 files; examples: apps/desktop/src-tauri/src/playlist_commands.rs, apps/desktop/src-tauri/src/playlist_state.rs, apps/desktop/src-tauri/src/playlists.rs, apps/desktop/src-tauri/src/provider.rs, apps/desktop/src-tauri/src/shadow_playlists.rs; 5 omitted; skipped: none; context (not coverage): 5 files; examples: ARCHITECTURE.md, crates/retune-core/src/track_decisions.rs, docs/architecture/library.md, docs/architecture/persistence.md, docs/architecture/spotify.md; constraints: Review was limited to the assigned Rust implementation and test scope. Tests were not executed during this review.
  • tauri:config-ipc — complete (constrained); scope: 8 files; examples: apps/desktop/src-tauri/src/playlist_commands.rs, apps/desktop/src-tauri/src/playlist_state.rs, apps/desktop/src-tauri/src/playlists.rs, apps/desktop/src-tauri/src/provider.rs, apps/desktop/src-tauri/src/shadow_playlists.rs; 3 omitted; body-inspected: 8 files; examples: apps/desktop/src-tauri/src/playlist_commands.rs, apps/desktop/src-tauri/src/playlist_state.rs, apps/desktop/src-tauri/src/playlists.rs, apps/desktop/src-tauri/src/provider.rs, apps/desktop/src-tauri/src/shadow_playlists.rs; 3 omitted; skipped: none; context (not coverage): 8 files; examples: AGENTS.md, ARCHITECTURE.md, apps/desktop/src/App.tsx, apps/desktop/src/ShadowDiscovery.tsx, apps/desktop/src/spotifyGateway.ts; 3 omitted; constraints: Review limited to the assigned Tauri configuration and IPC boundary; validation results were not independently rerun.
  • security:credential-boundary — complete (constrained); scope: 3 files; examples: apps/desktop/src-tauri/src/provider.rs, apps/desktop/src-tauri/src/spotify_commands.rs, docs/architecture/spotify.md; body-inspected: 3 files; examples: apps/desktop/src-tauri/src/provider.rs, apps/desktop/src-tauri/src/spotify_commands.rs, docs/architecture/spotify.md; skipped: none; context (not coverage): 7 files; examples: AGENTS.md, ARCHITECTURE.md, apps/desktop/src-tauri/src/playlist_state.rs, apps/desktop/src-tauri/src/playlists.rs, apps/desktop/src-tauri/src/spotify_membership.rs; 2 omitted; constraints: Review limited to credential boundaries in the assigned changes.

0 PR discussion threads considered. 0 summarized; 0 resolved.


Completed in 1m 23s | gpt-6.1-sol, gpt-6.1-terra | cr 0.10.367
Field Value
Model gpt-6.1-sol, gpt-6.1-terra
Reviewers architecture:seams, frontend:view-state, rust:implementation-tests, tauri:config-ipc, security:credential-boundary
Engine codex_cli · gpt-6.1-sol, gpt-6.1-terra
Reviewed by cr · rianjs-bot[bot]
Duration 1m 23s wall · 2m 54s compute
Cost unavailable
Tokens 1.0M in / 6.2k out

Per-workstream usage

  • orchestrator-selection — gpt-6.1-terra
    • In: 37.6k
    • Out: 759
    • Cache read: 30.7k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 17s
  • architecture:seams — gpt-6.1-sol
    • In: 284.8k
    • Out: 1.6k
    • Cache read: 233.3k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 50s
  • frontend:view-state — gpt-6.1-terra
    • In: 76.6k
    • Out: 351
    • Cache read: 55.9k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 14s
  • rust:implementation-tests — gpt-6.1-terra
    • In: 256.1k
    • Out: 1.1k
    • Cache read: 227.7k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 35s
  • tauri:config-ipc — gpt-6.1-terra
    • In: 184.4k
    • Out: 1.1k
    • Cache read: 153.1k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 33s
  • security:credential-boundary — gpt-6.1-terra
    • In: 111.0k
    • Out: 449
    • Cache read: 83.5k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 16s
  • orchestrator-rollup — gpt-6.1-terra
    • In: 58.3k
    • Out: 797
    • Cache read: 50.2k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 5s

@rianjs
rianjs merged commit 0eaf8a5 into main Nov 9, 2026
8 checks passed
@rianjs
rianjs deleted the fix/playlist-batching-progress branch November 9, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant