Skip to content

In tmux, a review started while the PR's investigation window is open starts the review #425

Open

Description

@ooloth

Current state

In tmux, a review chosen from v on a PR whose i window is already open never runs: hub focuses the open window and the review's skill is never sent. A PR's investigation and its reviews share one tmux window name (domain/src/investigation_window.rs, tested by a_prs_investigation_and_reviews_share_a_tmux_name_but_not_a_label), and launch returns the open window for a name it finds (ui/tui/src/investigations/launch.rs:106).

Ideal state

  • In tmux, choosing a review on a PR whose investigation window is open starts that review's session

Decisions

Constraints

Open

No open decisions.

Starting points

  • domain/src/investigation_window.rs: how a PR's windows are named
  • ui/tui/src/investigations/launch.rs: where an open window is reused

Activity

  1. ooloth commented on Nov 19, 2026

    @ooloth
    OwnerAuthor

    The reuse return is now launch.rs:116, not :106. Since #435, it runs after the launcher check, so while the launcher is broken, i on a signal with an open window shows that error instead of switching to the window. The bug itself still stands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions