Skip to content

The checks in scripts/checks are Python #205

Open

Description

@ooloth

Current state

The scripts that check every change are themselves bash, so a mistake in one can let a broken change through without a type checker or test noticing. scripts/check.bash runs formatting.bash, docs.py, types.bash, linting.bash and tests.bash from scripts/checks/, with versions.bash and link-scripts.bash alongside them, and CI runs the same five as steps in .github/workflows/check.yml.

Ideal state

  • Every script in scripts/checks/ and scripts/check.bash is Python, tested by tests that import it
  • check and CI run the same categories in the same order as before, and fail on the same problems

Decisions

Constraints

Open

Starting points

  • scripts/check.bash: runs the categories in order
  • scripts/checks/tests.bash: the most involved of the checks
  • .github/workflows/check.yml: how CI runs them

Depends on

  • The sub-issue that sets up the repo-level Python project: the ported code needs the project to live in

Activity

  1. added
    maintenanceUpkeep that changes how the repo is built, not what it does
    on Oct 30, 2026
  2. ooloth commented on Oct 31, 2026

    @ooloth
    OwnerAuthor

    scripts/checks/linting.bash gained a step in a076d181 (#230): scripts/checks/private_values.py, a single-file uv script with tests in scripts/checks/tests/test_private_values.py. When the linting category moves to Python, two things come with it. One is the step that loads the main checkout's private.env when the environment has no PRIVATE_* values. The other is the rule that the check fails on a Mac with no values, and skips only its search when CI or AMP_ORB is set. Loading the file from Python would mean a second parser beside tools/bash/private-env.bash, which zsh still needs, unless the Python step calls that bash function as linting.bash does today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    maintenanceUpkeep that changes how the repo is built, not what it does

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions