Open
Labels
maintenanceUpkeep that changes how the repo is built, not what it doesUpkeep that changes how the repo is built, not what it does
Description
Current state
The scripts that check every change are themselves bash, so a mistake in one can let a broken change through without a type checker or test noticing. scripts/check.bash runs formatting.bash, docs.py, types.bash, linting.bash and tests.bash from scripts/checks/, with versions.bash and link-scripts.bash alongside them, and CI runs the same five as steps in .github/workflows/check.yml.
Ideal state
- Every script in
scripts/checks/andscripts/check.bashis Python, tested by tests that import it checkand CI run the same categories in the same order as before, and fail on the same problems
Decisions
Constraints
- 007 — Scripts that are run, not sourced, are written in Python: these scripts move to Python
- 008 — The repo's Python is one uv project at the repo root: the ported code and its tests live in that project
- 005 — Checks are grouped by category in
scripts/checks/, and run fastest first: the categories, their order and CI's one step per category stay
Open
- What command starts the repo's Python? (new CLI contract) Open in what-command-starts-the-repos-python.md. It is settled before Every tool's link step is Python #206, the first category to use it.
Starting points
scripts/check.bash: runs the categories in orderscripts/checks/tests.bash: the most involved of the checks.github/workflows/check.yml: how CI runs them
Depends on
- The sub-issue that sets up the repo-level Python project: the ported code needs the project to live in
Metadata
Metadata
Assignees
Labels
maintenanceUpkeep that changes how the repo is built, not what it doesUpkeep that changes how the repo is built, not what it does
Activity
ooloth commentedon Oct 31, 2026
scripts/checks/linting.bashgained a step ina076d181(#230):scripts/checks/private_values.py, a single-file uv script with tests inscripts/checks/tests/test_private_values.py. When the linting category moves to Python, two things come with it. One is the step that loads the main checkout'sprivate.envwhen the environment has noPRIVATE_*values. The other is the rule that the check fails on a Mac with no values, and skips only its search whenCIorAMP_ORBis set. Loading the file from Python would mean a second parser besidetools/bash/private-env.bash, which zsh still needs, unless the Python step calls that bash function aslinting.bashdoes today.