Repository navigation
fix(clippy): resolve new lints from Rust 1.99 - #130
Merged
Merged
Conversation
- manual_is_variant_and: use Result::is_ok_and. - unused_async_trait_impl: allow it where unused_async is already allowed, because actix handlers and the mock certificate function must stay async. - assert_is_empty: use assert_eq!/assert_ne! in tests. Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manual_is_variant_and: useResult::is_ok_andinreconnection.rs.unused_async_trait_impl: allow it next to the existingunused_asyncallows inapi.rsand the mockcreate_module_certificate. Actix handlers and the mock function must stay async.assert_is_empty: useassert_eq!/assert_ne!in three tests.Reason
CI runs clippy with the current stable toolchain (Rust 1.99), which adds these lints. With
-D warningsthey fail the QA build on main.The new lint name is unknown to older clippy versions, so clippy before 1.99 reports
unknown lint: clippy::unused_async_trait_impl. Update the local toolchain withrustup update stable.