Repository navigation
fix: preserve semicolon path parameters in DPoP proofs - #607
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DPoP proofs currently drop semicolon parameters from the last URL path segment, so the signed htu does not match the requested HTTP URI. Use urlsplit/urlunsplit to preserve the complete path, while still removing query and fragment.
Three semicolon cases fail before this patch; encoded semicolons and parameters in earlier path segments pass as controls. New regression verifies the actual generated JWT signature using the public JWK, then checks its htu. All 85 DPoP tests and five subtests pass; the remaining 239 non-integration tests pass. Repository fatal Flake8 check and diff check pass. Python3.12, pinned requirements; no live Okta organization calls or full Python matrix.
The Okta CLA was electronically signed and emailed to CLA@okta.com on October 27, 2026, following explicit contributor authorization. Okta recording/confirmation is pending.