Repository navigation
fix(jj): move sign-on-push to the revsets config - #393
Merged
Merged
Conversation
- jj 0.46 deprecates git.sign-on-push and warns on every command. - Set revsets.git-sign-on-push to "~signed() & mine()", the replacement jj suggests. It signs the same commits at push time as before. - Signing still happens only on push: signing.behavior stays "drop".
odsod
force-pushed
the
fix/jj-sign-on-push
branch
from
November 5, 2026 10:39
727437c to
08ea3da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
jj 0.46 deprecates
git.sign-on-pushand prints a warning on every command.What
jj/config.toml: dropgit.sign-on-push = trueand setrevsets.git-sign-on-push = "~signed() & mine()", the replacement jj suggests.signing.behaviorstays"drop".Verification
jj stno longer prints the warning.jj config get revsets.git-sign-on-pushreturns~signed() & mine().