Repository navigation
test(pick): fix a builtin.help() test after Nightly changes - #2584
Merged
Merged
Conversation
echasnovski
reviewed
Oct 16, 2026
| -- Ignore footer as it contains non-reliable number of help tags | ||
| child.expect_screenshot({ ignore_text = { 14 } }) | ||
| -- Ignore attr on Neovim<0.13 as the tree-sitter-vimdoc grammar changed | ||
| child.expect_screenshot({ ignore_text = { 14 }, ignore_attr = child.fn.has('nvim-0.13') == 0 and true or false }) |
Member
There was a problem hiding this comment.
Suggested change
| child.expect_screenshot({ ignore_text = { 14 }, ignore_attr = child.fn.has('nvim-0.13') == 0 and true or false }) | |
| child.expect_screenshot({ ignore_text = { 14 }, ignore_attr = child.fn.has('nvim-0.13') == 0 }) |
echasnovski
reviewed
Oct 16, 2026
| 12|│ typing CTRL-R and the second char│ | ||
| 13|│ to indicate that you are expected│ | ||
| 14|└ Help ──────────────────────────────── 1|1|11861 ┘ | ||
| 14|└ Help ──────────────────────────────── 1|1|11341 ┘ |
Member
There was a problem hiding this comment.
Hmm... I am curious why we have different number of overall tags. If I run this test on the latest Nightly, I have it updated to 1|1|12221 line. Could you please remove this line change? This text line is ignored in the test comparison, while having it go down is unintuitive.
Member
Author
There was a problem hiding this comment.
Done.
I am using a manual build on arch linux, like so: make CMAKE_BUILD_TYPE=RelWithDebInfo CMAKE_EXTRA_FLAGS="-DCMAKE_INSTALL_PREFIX=$HOME/neovim" && make install. Perhaps that's a factor?
Member
abeldekat
force-pushed
the
fix_pick_help
branch
from
October 16, 2026 08:37
fc72307 to
345f504
Compare
Details: - The tree-sitter-vimdoc grammar changed slightly - See PR 42367 in neovim/neovim
abeldekat
force-pushed
the
fix_pick_help
branch
from
October 16, 2026 08:41
345f504 to
e232576
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
The tree-sitter-vimdoc grammar changed slightly, see tree-sitter-vimdoc, PR 174
See PR 42367 in neovim/neovim
On line 6 the highlighting changed for the space after
CTRL-K.Another approach I can think of is to not regenerate the screenshot and
ignore_attrwhen Neovim>=0.13.