fix: backport recent v2 beta fixes to 1.x - #932
Conversation
Keep consent changes effective before Meta Pixel loads, let callers own PageView tracking, and use canonical registry keys during bundling. Render Google Maps overlays consistently during hydration.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
🤖 MERGED
GitHub merged this pull request.
No Repair remains on the default branch: Finding is false at this head. The worktree starts at the current default branch (origin/main, v2) at b4f097c, where ScriptGoogleMapsHeatmapLayer.vue does not exist: it was removed by 2db3380 'refa |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe changes add a Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The supplied evidence identifies no issue that needs resolution before merge. Normal checks can proceed. Security Architecture ReviewSecurity architecture risk: 🟡 Moderate · up to A consent grant made before Meta Pixel finishes loading can move ahead of tracking events recorded while consent was denied. Whether those earlier events are subsequently sent depends on the pixel SDK, so this is a meaningful privacy risk rather than a verified disclosure. Retained concerns
Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 9 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The canonical registry key now activates bundling for TikTok Pixel. Keep the protocol fixture on the direct SDK path and cover proxy rewriting separately.
🔗 Linked issue
Related to #925.
📚 Description
1.x still queues Meta Pixel consent changes behind the default consent state.
It also forces an initial PageView and guesses some registry keys during bundling.
Google Maps overlays render different nodes on the server and client.
This backports #930, #931, #926, and the Google Maps part of #914.