Conversation
Contributor
|
I'm going through all the documentation right now so I'm not sure this will be necessary. I'll try to post a link so you can confirm when I send my PR. |
Author
Do I close this PR? |
Contributor
|
ya, we can close it now. and reopen another one later if i missed some points. |
Contributor
|
My docs update PR is live now #2253 Let me know if anything looks wrong. |
Author
|
I glanced over the article I modified in this PR. Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My custom completer stopped working due to a breaking change introduced in 0.116.0. I went to to check the documentation for the new command just to notice that the documentation is broken in many places.
Some of the functions use a positional parameter, space, even though that doesn't exist. Some functions and parts of the text still refer to $spans, even though that has been removed in favor of the new alternatives. Moreover, some match statements try to match $place.command as a whole instead of selecting its first element.
I made this a draft since I haven't personally tested each of the functions I modified.
Apparently this modification was introduced in #2250. Seems like nobody bothered to check the diffs?