Repository navigation
Remove unused package XmlSerializer from TCP agent startup - #17
Merged
Merged
Conversation
Add a constructor regression and correct the test project reference casing for case-sensitive filesystems. Developed and validated jointly with OpenAI Codex.
CharliePoole
self-requested a review
October 17, 2026 06:20
Member
|
Holding till after beta release |
CharliePoole
approved these changes
Oct 21, 2026
CharliePoole
left a comment
CharliePoole
left a comment
Member
There was a problem hiding this comment.
Thanks. Like the tests added.
oznetmaster
referenced
this pull request
Oct 21, 2026
oznetmaster
marked this pull request as ready for review
October 21, 2026 05:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unused
TestPackageXmlSerializer from TCP transport construction, add an initialization smoke test, and correct the test project's agent-core reference casing for case-sensitive filesystems.Updated onto Agent.Core tag
4.0.0-beta.6(bb42cb55), using Engine.Api beta.101 and Extensibility beta.6. Pin the source build's NUnit.Common dependency to public beta.5; the release source still specifies beta.4.16, which is absent from NuGet.org.The original failure was demonstrated with API beta.100, whose non-public collection mutation caused serializer construction to throw before agent registration. API beta.101 restores public mutation and resolves that particular startup failure. This draft now represents unused-code cleanup and portable test-build maintenance, not a claim that unchanged beta.6 still has the beta.100 startup defect. The smoke test passes on the updated graph; its earlier failing-before evidence applies only to the recorded beta.100 baseline.
Validation: the standalone refreshed branch builds without warnings/errors. Complete Windows suites pass 48 with one existing skip on .NET 8 and 82 with two existing skips on CLR. The combined startup/stop stack also passes native desktop Console/recovery controls and 14 focused agent regressions on actual Linux Mono. These are separately identified scopes, not a claim of fresh native source builds.
No framework selection, remote-provider, deployment or cancellation behavior is changed by this PR.
Acknowledgments: investigated, implemented and validated jointly by Neil Colvin (@oznetmaster) and OpenAI Codex.