Repository navigation
Conversation
carpawell
force-pushed
the
feat/contracts-with-original-requests
branch
from
October 22, 2026 17:34
261b014 to
11dbdf2
Compare
carpawell
marked this pull request as ready for review
October 22, 2026 17:39
carpawell
requested review from
End-rey,
cthulhu-rider and
roman-khimov
as code owners
October 22, 2026 17:40
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved authorization gaps and signature compatibility regressions can approve unauthorized changes or reject legitimate requests.
7 open issues
What changed in this PR
This PR carries original container API requests through contract calls so Inner Ring processors can validate them before approving container creation, deletion, and eACL updates.
Changes:
- Forward serialized requests from the container service through blockchain clients.
- Parse original-request contract arguments and add Inner Ring validation.
- Update the contract dependency, test doubles, and changelog.
| File | Description |
|---|---|
pkg/services/container/service_internal_test.go |
Update mock contract signatures. |
pkg/services/container/server.go |
Serialize and forward original API requests. |
pkg/services/container/server_test.go |
Adapt test contracts to the new parameters. |
pkg/morph/event/container/notary_requests.go |
Parse legacy and original-request call formats. |
pkg/morph/contracts/methods.go |
Add original-request fields to contract parameters. |
pkg/morph/client/container/put.go |
Support creation calls carrying original requests. |
pkg/morph/client/container/eacl_set.go |
Support eACL calls carrying original requests. |
pkg/morph/client/container/delete.go |
Support deletion calls carrying original requests. |
pkg/innerring/processors/container/process_eacl.go |
Add original-request validation for eACL updates. |
pkg/innerring/processors/container/process_container.go |
Add shared request validation for container operations. |
go.sum |
Update contract dependency checksums. |
go.mod |
Advance the contract dependency. |
cmd/neofs-node/container.go |
Forward original requests to blockchain clients. |
CHANGELOG.md |
Document Inner Ring request validation. |
Review effort: Balanced
| signedReq, _ := protoencoding.EncodeRequest(nil, reqBody, reqMetaHeader) | ||
| sig := reqVerifHeader.GetRequestSignature() | ||
|
|
||
| err := cp.verifySignature(signatureVerificationData{ |
carpawell
added a commit
to nspcc-dev/neofs-sdk-go
that referenced
this pull request
Oct 23, 2026
These cases are special, they require any signature routine to be done by container owner, that is why it is passed as a func param. In particular, it allows nspcc-dev/neofs-node#4245 exchanging container, containerID, and container eACL signatures with the whole request signatures. Refs nspcc-dev/neofs-api#446. Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
carpawell
force-pushed
the
feat/contracts-with-original-requests
branch
from
October 23, 2026 16:47
11dbdf2 to
1c3bac2
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4245 +/- ##
==========================================
- Coverage 32.35% 32.26% -0.10%
==========================================
Files 673 673
Lines 41430 41610 +180
==========================================
+ Hits 13406 13424 +18
- Misses 28024 28186 +162 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
carpawell
added
blocked
It now has original API request for calls that are initiated by external users. Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
It now has container RPC signed by container owner (or by an authorized key) and allows IRs checking original requests by its signatures, not by request fields. Refs nspcc-dev/neofs-api#446, nspcc-dev/neofs-sdk-go#898. Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
Implementation of nspcc-dev/neofs-contract#637. Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
carpawell
force-pushed
the
feat/contracts-with-original-requests
branch
from
October 26, 2026 16:54
1c3bac2 to
b6eb42e
Compare
| withOptionalEacl bool | ||
| err error | ||
| ) | ||
|
|
| signedReq, _ := protoencoding.EncodeRequest(nil, reqBody, reqMetaHeader) | ||
| sig := reqVerifHeader.GetRequestSignature() | ||
|
|
||
| err := cp.verifySignature(signatureVerificationData{ |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved authorization and replay-protection gaps, along with legacy-client compatibility failures, block approval.
5 open issues
6 resolved since last review
Review effort: Balanced
| } | ||
|
|
||
| err = cp.checkSetEACL(*req.EACLTable, table, id, cnr) | ||
| err = cp.checkSetEACL(*req.EACLTable, table, id, cnr, req.OriginalRequest == nil) |
Comment on lines
+378
to
+379
| if !multipleReqSignatures(reqMetaHeader) { | ||
| return nil |
| return fmt.Errorf("container ID in the original request does not match the contract one") | ||
| } | ||
|
|
||
| return cp.checkOriginalRequest(cnr, cID, session.VerbContainerSetEACL, sessionv2.VerbContainerSetEACL, apiReq.GetBody(), apiReq.GetMetaHeader(), apiReq.GetVerifyHeader()) |
Comment on lines
+398
to
+402
| verifData.signedData = signedData | ||
| verifData.verifScript = sig.GetKey() | ||
| verifData.invocScript = sig.GetSign() | ||
|
|
||
| err = cp.verifySignature(verifData) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.