Skip to content

build: remove default values for libname - #66790

Open
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:no-default-libname
Open

aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:no-default-libname

Conversation

@aduh95

@aduh95 aduh95 commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

By setting a default value, we override the pkg-config value, which is inconsistent with the other --shared-• flags.

@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels Oct 16, 2026
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Oct 16, 2026
By setting a default value, we override the pkg-config value,
which is inconsistent with the other `--shared-*` flags.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

@legendecas legendecas left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node/configure.py

Lines 2200 to 2205 in f205c37

default_libs = getattr(options, shared_lib + '_libname')
if default_libs:
libraries += [f'-l{l}' for l in default_libs.split(',')]
elif pkg_libs:
libraries += pkg_libs.split()
silently ignores a shared lib if no pkg config found, when --shared-* is set, without --shared-*-libname. Should it infer the default_libs from the lib name, and yield to the linker at build-time?

@legendecas

Copy link
Copy Markdown
Member

I think the default_libs serves as a default value, yielding to the linter to find the library location at build-time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants