Skip to content

deps: use non-SIMD llhttp on the RISC-V architecture - #66785

Closed
hrw wants to merge 1 commit into
nodejs:mainfrom
hrw:no-simd-on-riscv
Closed

hrw wants to merge 1 commit into
nodejs:mainfrom
hrw:no-simd-on-riscv

Conversation

@hrw

@hrw hrw commented Oct 16, 2026

Copy link
Copy Markdown

There is no support for RISC-V in undici/llhttp yet so test fails:

Test failed: test//es-module/test-wasm-web-api.js
Test failure message:
node:internal/process/promises:394
    triggerUncaughtException(err, true /* fromPromise */);
    ^
[TypeError: fetch failed] {
  [cause]: HTTPParserError: Response does not match the HTTP/1.1 protocol (Invalid header value char)
      at Parser.createError (node:internal/deps/undici/undici:7417:16)
      at Parser.execute (node:internal/deps/undici/undici:7378:26)
      at Parser.readMore (node:internal/deps/undici/undici:7341:16)
      at Socket.onHttpSocketReadable (node:internal/deps/undici/undici:7821:22)
      at Socket.emit (node:events:514:28)
      at emitReadable_ (node:internal/streams/readable:845:12)
      at process.processTicksAndRejections (node:internal/process/task_queues:89:21) {
    code: undefined,
    data: 'Oct 2026 22:38:29 GMT\r\n' +
      'Connection: keep-alive\r\n' +
      'Keep-Alive: timeout=5\r\n' +
      'Content-Length: 41\r\n' +
      '\r\n' +
      '\x00asm\x01\x00\x00\x00\x01\x07\x01`\x02\x7F\x7F\x01\x7F\x03\x02\x01\x00\x07\x07\x01\x03add\x00\x00\n' +
      '\t\x01\x07\x00 \x00 \x01j\x0B'
  }
}

Use of non-SIMD version make test pass.

Observed in NodeJS 24.21.0 version.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. labels Oct 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

There is no support for RISC-V in undici/llhttp yet so tests fail:

Test failed: test//es-module/test-wasm-web-api.js
Test failed: test//parallel/test-inspector-network-content-type.js

Use of non-SIMD version make tests pass.

Observed in NodeJS 24.21.0 version.

Signed-off-by: Marcin Juszkiewicz <mjuszkiewicz@redhat.com>
@hrw
hrw force-pushed the no-simd-on-riscv branch from 24ae85d to f807f9f Compare October 16, 2026 10:35
@richardlau

Copy link
Copy Markdown
Member

This change needs to be made in https://github.com/nodejs/undici otherwise it is going to get overwritten by the automation that updates undici in Node.js.

@richardlau

Copy link
Copy Markdown
Member

Also @nodejs/platform-riscv64 since this doesn't seem to be something that has already been mentioned in nodejs/build#4099.

@hrw

hrw commented Oct 16, 2026

Copy link
Copy Markdown
Author

Reported as nodejs/undici#6041

@hrw hrw closed this Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants