Skip to content

quic: reuse header support assertion #66777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
efekrskl wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −16
Open

quic: reuse header support assertion #66777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 4 additions & 16 deletions lib/internal/quic/quic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2160,10 +2160,7 @@ class QuicStream {
sendHeaders(headers, options = kEmptyObject) {
assertIsQuicStream(this);
if (this.destroyed) return false;
if (getQuicSessionState(this.#inner.session).headersSupported === 2) {
throw new ERR_INVALID_STATE(
'The negotiated QUIC application protocol does not support headers');
}
assertHeadersSupported(this.#inner.session);
validateObject(headers, 'headers');
const { terminal = false } = options;
const headerString = buildNgHeaderString(
Expand All @@ -2182,10 +2179,7 @@ class QuicStream {
sendInformationalHeaders(headers) {
assertIsQuicStream(this);
if (this.destroyed) return false;
if (getQuicSessionState(this.#inner.session).headersSupported === 2) {
throw new ERR_INVALID_STATE(
'The negotiated QUIC application protocol does not support headers');
}
assertHeadersSupported(this.#inner.session);
validateObject(headers, 'headers');
const headerString = buildNgHeaderString(
headers, assertValidPseudoHeader, true);
Expand All @@ -2203,10 +2197,7 @@ class QuicStream {
sendTrailers(headers) {
assertIsQuicStream(this);
if (this.destroyed) return false;
if (getQuicSessionState(this.#inner.session).headersSupported === 2) {
throw new ERR_INVALID_STATE(
'The negotiated QUIC application protocol does not support headers');
}
assertHeadersSupported(this.#inner.session);
validateObject(headers, 'headers');
const headerString = buildNgHeaderString(headers);
return sendHeaders(
Expand Down Expand Up @@ -2678,10 +2669,7 @@ class QuicStream {
[kSendHeaders](headers, kind = kHeadersKindInitial,
flags = kHeadersFlagsTerminal) {
validateObject(headers, 'headers');
if (getQuicSessionState(this.#inner.session).headersSupported === 2) {
throw new ERR_INVALID_STATE(
'The negotiated QUIC application protocol does not support headers');
}
assertHeadersSupported(this.#inner.session);
if (this.pending) {
debug('pending stream enqueuing headers', headers);
} else {
Expand Down
Loading