Repository navigation
Conversation
Signed-off-by: lazerg <lazerg2@gmail.com>
Collaborator
|
Review requested:
|
Contributor
|
Caution AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context. |
Signed-off-by: lazerg <lazerg2@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66769 +/- ##
==========================================
- Coverage 90.49% 90.49% -0.01%
==========================================
Files 797 797
Lines 277598 277601 +3
Branches 53336 53332 -4
==========================================
Hits 251220 251220
+ Misses 16790 16789 -1
- Partials 9588 9592 +4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #66760
When the first
sqlite3_backup_step()call returnsSQLITE_BUSYorSQLITE_LOCKED(for example because the source connection is inside a write transaction),sqlite3_backup_remaining()is still 0, so the job was not rescheduled. It then fell through to theSQLITE_DONEcheck and rejected with an error read from the destination connection: errcode 0, "not an error".Both codes are retryable per the SQLite docs, so the job now reschedules the step whenever it gets one of them, whatever the remaining page count.