esm: preserve syntax error locations in dynamic imports - #66402
Open
GiHoon1123 wants to merge 1 commit into
Open
GiHoon1123 wants to merge 1 commit into
GiHoon1123 wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
Signed-off-by: GiHoon1123 <rlaejrqo465@naver.com>
GiHoon1123
force-pushed
the
fix/esm-dynamic-import-syntax-error
branch
from
September 30, 2026 05:39
ff63ef4 to
68f2343
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamic imports of modules with syntax errors currently reject with a stack that points into the ESM loader instead of the module source. The compile path already records the source excerpt, but this error is raised before a ModuleJob can decorate the stack.
Decorate translator errors at the loader boundary and cover a caught dynamic import so the filename, line, and source location are retained.
Fixes: #49441
Tests: