Repository navigation
feat: add && syntax for AND conditions in skip entries - #1193
Open
BethGriggs wants to merge 1 commit into
Open
BethGriggs wants to merge 1 commit into
BethGriggs wants to merge 1 commit into
Conversation
Allows combining multiple match conditions with && in a single string, so a skip only applies when all parts match. For example: "skip": ["win32", "aix && >=26"] Previously only OR logic was possible (array items are OR'd). The new syntax works with any existing condition type: semver ranges, platform, arch, platform-arch combos, distro, endian, and fips. Assisted-by: IBM Bob Signed-off-by: Beth Griggs <bethanyngriggs@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1193 +/- ##
==========================================
+ Coverage 96.20% 96.21% +0.01%
==========================================
Files 29 29
Lines 2213 2219 +6
==========================================
+ Hits 2129 2135 +6
Misses 84 84 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows combining multiple match conditions with && in a single string, so a skip only applies when all parts match. For example:
"skip": ["win32", "aix && >=26"]
Previously only OR logic was possible (array items are OR'd). The new syntax works with any existing condition type: semver ranges, platform, arch, platform-arch combos, distro, endian, and fips.
Assisted-by: IBM Bob
Checklist
npm testpasseshere