Repository navigation
lookup: unskip fastify on S390x - #1186
Merged
Merged
Conversation
2 tasks done
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1186 +/- ##
=======================================
Coverage 96.20% 96.20%
=======================================
Files 29 29
Lines 2213 2213
=======================================
Hits 2129 2129
Misses 84 84 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sxa
approved these changes
Oct 7, 2026
Member
|
@abhayagarwal-dev, just a suggestion for future - when triaging/testing on s390x only, you could untick other platforms in the CI runs to reduce strain on CI. |
BethGriggs
approved these changes
Oct 8, 2026
Contributor
Author
Sure , I'll keep it in mind from next time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a replacement for #1160 which was accidentally closed while squashing commits to maintain a clean commit history. The changes are identical.
Fastifyis marked as skip onS390xbut the CI run shows that it is passing successfully. This PR unskipsS390xfromfastifyskip list.CI: https://ci.nodejs.org/job/citgm-smoker-pipeline/296/
CITGM smoke test passed on s390x with Node.js v22.23.2
Checklist
npm testpasses