Skip to content

lookup: unskip fastify on S390x - #1186

Merged
BethGriggs merged 1 commit into
nodejs:mainfrom
abhayagarwal-dev:unskip-s390
Oct 8, 2026
Merged

BethGriggs merged 1 commit into
nodejs:mainfrom
abhayagarwal-dev:unskip-s390

Conversation

@abhayagarwal-dev

Copy link
Copy Markdown
Contributor

This PR is a replacement for #1160 which was accidentally closed while squashing commits to maintain a clean commit history. The changes are identical.

Fastify is marked as skip on S390x but the CI run shows that it is passing successfully. This PR unskips S390x from fastify skip list.

CI: https://ci.nodejs.org/job/citgm-smoker-pipeline/296/

CITGM smoke test passed on s390x with Node.js v22.23.2

$ citgm fastify
info: starting            | fastify
info: lookup              | fastify
info: lookup-found        | fastify
info: fastify lookup-replace| https://github.com/fastify/fastify/archive/ba235fdcd9a83a4c7ccf793f7b2596a8f65389b6.tar.gz
info: fastify npm:        | Downloading project: https://github.com/fastify/fastify/archive/ba235fdcd9a83a4c7ccf793f7b2596a8f65389b6.tar.gz
info: fastify npm:        | Project downloaded ba235fdcd9a83a4c7ccf793f7b2596a8f65389b6.tar.gz
info: fastify npm:        | npm install started
info: fastify npm:        | npm install successfully completed
info: fastify npm:        | test suite started
info: passing module(s)   |
info: module name:        | fastify
info: version:            | 5.12.5
info: done                | The smoke test has passed.
info: duration            | test duration: 112615ms
Checklist
  • npm test passes
  • contribution guidelines followed here

@abhayagarwal-dev abhayagarwal-dev mentioned this pull request Oct 7, 2026
2 tasks done
@codecov-commenter

codecov-commenter commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (3b60eb7) to head (4a0f287).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1186   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files          29       29           
  Lines        2213     2213           
=======================================
  Hits         2129     2129           
  Misses         84       84           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BethGriggs

Copy link
Copy Markdown
Member

@abhayagarwal-dev, just a suggestion for future - when triaging/testing on s390x only, you could untick other platforms in the CI runs to reduce strain on CI.

@BethGriggs
BethGriggs merged commit 17e7dea into nodejs:main Oct 8, 2026
11 checks passed
@abhayagarwal-dev

Copy link
Copy Markdown
Contributor Author

@abhayagarwal-dev, just a suggestion for future - when triaging/testing on s390x only, you could untick other platforms in the CI runs to reduce strain on CI.

Sure , I'll keep it in mind from next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants