Repository navigation
Should nodejs/node#63869 (--experimental-strip-private-modules) land? - #1900
github-actions[bot] wants to merge 23 commits into
Conversation
…ivate-modules`) land?"
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Ping @anonrig @BridgeAR @RaisinTen |
Signed-off-by: Darshan Sen <raisinten@gmail.com>
|
Last ping @BridgeAR |
|
@nodejs/tsc lets close the vote (I don't have access to a machine so I count on you) |
|
I would like to close this vote, and for this effect, I'm revealing my key part: |
|
I would like to close this vote, and for this effect, I'm revealing my key part: |
|
I would like to close this vote, and for this effect, I'm revealing my key part: |
Election resultsSubject: Should nodejs/node#63869 ( ResultsWinning candidate: Land nodejs/node#63869: add Table of results
Voting dataParticipants:
Private key to decrypt ballotsDiscarded commitsSome commits have not been taken into account when counting the ballots: [
{
"commitInfo": {
"sha": "ef077887915d16e65920097fc65643394980a115",
"signatureStatus": "E",
"author": "Antoine du Hamel <duhamelantoine1995@gmail.com>",
"files": [],
"deletedFiles": [
"votes/strip-private-modules/mcollina.json"
]
},
"reason": "This commit deletes some files."
},
{
"commitInfo": {
"sha": "8f60e6808c7ffefab1e5389808eee08325326405",
"signatureStatus": "E",
"author": "Matteo Collina <matteo.collina@gmail.com>",
"files": [
".editorconfig",
".github/dependabot.yml",
".github/workflows/ci.yml",
".github/workflows/closeVote.yml",
".github/workflows/initiateNewVote.yml",
".github/workflows/remark-lint-problem-matcher.json",
".github/workflows/watchVote.yml",
".gitignore",
".mailmap",
".remarkrc",
"CODE_OF_CONDUCT.md",
"Member-Travel-Fund.md",
"Moderation-Policy.md",
"Nodejs-Bug-Bounty-Security-Fund.md",
"Nodejs-Funding-Sources.md",
"ONBOARDING.md",
"OpenSSL-Strategy.md",
"README.md",
"Strategic-Initiatives.md",
"Streaming/Streaming-To-Youtube.md",
"Streaming/youtube-stream-analytics.png",
"Streaming/youtube-stream-share.png",
"Streaming/youtube-stream-status.png",
"Streaming/youtube-stream-title-description.png",
"TSC-Charter.md",
"WORKING_GROUPS.md",
"meetings/2015-05-27.md",
"meetings/2015-06-03.md",
"meetings/2015-06-10.md",
"meetings/2015-06-17.md",
"meetings/2015-07-01.md",
"meetings/2015-07-08.md",
"meetings/2015-07-15.md",
"meetings/2015-07-22.md",
"meetings/2015-07-29.md",
"meetings/2015-08-12.md",
"meetings/2015-08-19.md",
"meetings/2015-08-26.md",
"meetings/2015-09-02.md",
"meetings/2015-09-16.md",
"meetings/2015-09-30.md",
"meetings/2015-10-07.md",
"meetings/2015-10-14.md",
"meetings/2015-10-21.md",
"meetings/2015-12-03.md",
"meetings/2016-01-07.md",
"meetings/2016-01-14.md",
"meetings/2016-01-21.md",
"meetings/2016-01-28.md",
"meetings/2016-02-04.md",
"meetings/2016-02-11.md",
"meetings/2016-02-18.md",
"meetings/2016-03-03.md",
"meetings/2016-03-10.md",
"meetings/2016-03-17.md",
"meetings/2016-03-24.md",
"meetings/2016-04-07.md",
"meetings/2016-04-21.md",
"meetings/2016-05-05.md",
"meetings/2016-05-19.md",
"meetings/2016-06-16.md",
"meetings/2016-06-30.md",
"meetings/2016-07-14.md",
"meetings/2016-08-04.md",
"meetings/2016-08-11.md",
"meetings/2016-08-25.md",
"meetings/2016-09-08.md",
"meetings/2016-09-22.md",
"meetings/2016-10-06.md",
"meetings/2016-10-20.md",
"meetings/2016-11-03.md",
"meetings/2016-11-17.md",
"meetings/2016-12-15.md",
"meetings/2017-01-12.md",
"meetings/2017-01-26.md",
"meetings/2017-02-09.md",
"meetings/2017-02-23.md",
"meetings/2017-03-09.md",
"meetings/2017-03-23.md",
"meetings/2017-04-06.md",
"meetings/2017-06-01.md",
"meetings/2017-06-29.md",
"meetings/2017-09-13.md",
"meetings/2017-09-20.md",
"meetings/2017-09-27.md",
"meetings/2017-10-11.md",
"meetings/2017-10-18.md",
"meetings/2017-10-25.md",
"meetings/2017-11-01.md",
"meetings/2017-11-08.md",
"meetings/2017-11-15.md",
"meetings/2017-11-22.md",
"meetings/2017-11-29.md",
"meetings/2017-12-06.md",
"meetings/2017-12-13.md",
"meetings/2017-12-20.md",
"meetings/2018-01-10.md",
"meetings/2018-01-17.md",
"meetings/2018-01-31-V8.md",
"meetings/2018-01-31.md",
"meetings/2018-02-07.md",
"meetings/2018-02-21.md",
"meetings/2018-02-28.md",
"meetings/2018-03-07.md",
"meetings/2018-03-14.md",
"meetings/2018-03-21.md",
"meetings/2018-03-28.md",
"meetings/2018-04-04.md",
"meetings/2018-04-11.md",
"meetings/2018-04-18.md",
"meetings/2018-04-25.md",
"meetings/2018-05-02.md",
"meetings/2018-05-09.md",
"meetings/2018-05-16.md",
"meetings/2018-05-23.md",
"meetings/2018-06-06.md",
"meetings/2018-06-13.md",
"meetings/2018-06-20.md",
"meetings/2018-06-27.md",
"meetings/2018-07-12.md",
"meetings/2018-07-18.md",
"meetings/2018-08-01.md",
"meetings/2018-08-08.md",
"meetings/2018-08-22.md",
"meetings/2018-08-29.md",
"meetings/2018-09-05.md",
"meetings/2018-09-12.md",
"meetings/2018-09-19.md",
"meetings/2018-09-26.md",
"meetings/2018-10-03.md",
"meetings/2018-10-17.md",
"meetings/2018-10-24.md",
"meetings/2018-10-31.md",
"meetings/2018-11-07.md",
"meetings/2018-11-14.md",
"meetings/2018-12-05.md",
"meetings/2018-12-12.md",
"meetings/2018-12-19.md",
"meetings/2019-01-02.md",
"meetings/2019-01-16.md",
"meetings/2019-01-23.md",
"meetings/2019-01-30.md",
"meetings/2019-02-14.md",
"meetings/2019-02-20.md",
"meetings/2019-03-14.md",
"meetings/2019-03-27.md",
"meetings/2019-04-10.md",
"meetings/2019-04-17.md",
"meetings/2019-04-24.md",
"meetings/2019-05-15.md",
"meetings/2019-06-05.md",
"meetings/2019-06-19.md",
"meetings/2019-06-26.md",
"meetings/2019-07-03.md",
"meetings/2019-07-10.md",
"meetings/2019-07-24.md",
"meetings/2019-07-29.md",
"meetings/2019-08-07.md",
"meetings/2019-08-14.md",
"meetings/2019-08-21.md",
"meetings/2019-08-28.md",
"meetings/2019-09-11.md",
"meetings/2019-09-18.md",
"meetings/2019-09-25.md",
"meetings/2019-10-16.md",
"meetings/2019-10-23.md",
"meetings/2019-11-06.md",
"meetings/2019-11-20.md",
"meetings/2019-11-27.md",
"meetings/2019-12-04.md",
"meetings/2020-01-08.md",
"meetings/2020-01-15.md",
"meetings/2020-01-22.md",
"meetings/2020-02-05.md",
"meetings/2020-02-19.md",
"meetings/2020-02-26.md",
"meetings/2020-03-11.md",
"meetings/2020-03-18.md",
"meetings/2020-04-01.md",
"meetings/2020-04-08.md",
"meetings/2020-04-16.md",
"meetings/2020-04-23.md",
"meetings/2020-04-29.md",
"meetings/2020-05-07.md",
"meetings/2020-05-14.md",
"meetings/2020-05-21.md",
"meetings/2020-06-04.md",
"meetings/2020-07-02.md",
"meetings/2020-07-09.md",
"meetings/2020-07-16.md",
"meetings/2020-08-06.md",
"meetings/2020-08-13.md",
"meetings/2020-08-27.md",
"meetings/2020-09-03.md",
"meetings/2020-09-16.md",
"meetings/2020-09-24.md",
"meetings/2020-10-01.md",
"meetings/2020-10-08.md",
"meetings/2020-10-29.md",
"meetings/2020-11-11.md",
"meetings/2020-12-09.md",
"meetings/2021-01-14.md",
"meetings/2021-02-04.md",
"meetings/2021-02-25.md",
"meetings/2021-03-18.md",
"meetings/2021-03-25.md",
"meetings/2021-04-08.md",
"meetings/2021-04-15.md",
"meetings/2021-04-22.md",
"meetings/2021-04-29.md",
"meetings/2021-05-20.md",
"meetings/2021-06-10.md",
"meetings/2021-06-23.md",
"meetings/2021-07-01.md",
"meetings/2021-07-14.md",
"meetings/2021-07-22.md",
"meetings/2021-07-29.md",
"meetings/2021-08-04.md",
"meetings/2021-08-25.md",
"meetings/2021-09-23.md",
"meetings/2021-09-30.md",
"meetings/2021-10-06.md",
"meetings/2021-10-14.md",
"meetings/2021-10-21.md",
"meetings/2021-10-27.md",
"meetings/2021-11-04.md",
"meetings/2021-11-17.md",
"meetings/2021-12-02.md",
"meetings/2021-12-08.md",
"meetings/2021-12-16.md",
"meetings/2022-01-06.md",
"meetings/2022-01-13.md",
"meetings/2022-01-19.md",
"meetings/2022-01-26.md",
"meetings/2022-02-03.md",
"meetings/2022-02-10.md",
"meetings/2022-02-16.md",
"meetings/2022-02-23.md",
"meetings/2022-03-03.md",
"meetings/2022-03-10.md",
"meetings/2022-03-23.md",
"meetings/2022-03-31.md",
"meetings/2022-04-06.md",
"meetings/2022-04-13.md",
"meetings/2022-04-20.md",
"meetings/2022-04-27.md",
"meetings/2022-05-04.md",
"meetings/2022-05-11.md",
"meetings/2022-05-18.md",
"meetings/2022-05-25.md",
"meetings/2022-06-01.md",
"meetings/2022-06-15.md",
"meetings/2022-06-22.md",
"meetings/2022-06-29.md",
"meetings/2022-07-06.md",
"meetings/2022-07-13.md",
"meetings/2022-07-20.md",
"meetings/2022-07-27.md",
"meetings/2022-08-03.md",
"meetings/2022-08-10.md",
"meetings/2022-09-07.md",
"meetings/2022-09-21.md",
"meetings/2022-09-28.md",
"meetings/2022-10-12.md",
"meetings/2022-10-19.md",
"meetings/2022-11-02.md",
"meetings/2022-11-09.md",
"meetings/2022-11-23.md",
"meetings/2022-11-30.md",
"meetings/2022-12-07.md",
"meetings/2022-12-14.md",
"meetings/2022-12-21.md",
"meetings/2023-01-04.md",
"meetings/2023-01-11.md",
"meetings/2023-01-18.md",
"meetings/2023-01-25.md",
"meetings/2023-02-01.md",
"meetings/2023-02-15.md",
"meetings/2023-02-22.md",
"meetings/2023-03-08.md",
"meetings/2023-03-15.md",
"meetings/2023-03-22.md",
"meetings/2023-03-29.md",
"meetings/2023-04-12.md",
"meetings/2023-04-19.md",
"meetings/2023-05-03.md",
"meetings/2023-05-17.md",
"meetings/2023-05-24.md",
"meetings/2023-05-31.md",
"meetings/2023-06-07.md",
"meetings/2023-06-14.md",
"meetings/2023-06-21.md",
"meetings/2023-07-05.md",
"meetings/2023-07-12.md",
"meetings/2023-07-19.md",
"meetings/2023-07-26.md",
"meetings/2023-08-02.md",
"meetings/2023-08-23.md",
"meetings/2023-08-30.md",
"meetings/2023-09-06.md",
"meetings/2023-09-13.md",
"meetings/2023-09-20.md",
"meetings/2023-09-27.md",
"meetings/2023-10-04.md",
"meetings/2023-10-11.md",
"meetings/2023-10-18.md",
"meetings/2023-10-25.md",
"meetings/2023-11-08.md",
"meetings/2023-11-15.md",
"meetings/2023-11-22.md",
"meetings/2023-11-29.md",
"meetings/2023-12-06.md",
"meetings/2023-12-20.md",
"meetings/2024-01-03.md",
"meetings/2024-01-10.md",
"meetings/2024-01-17.md",
"meetings/2024-01-24.md",
"meetings/2024-01-31.md",
"meetings/2024-02-07.md",
"meetings/2024-02-21.md",
"meetings/2024-02-28.md",
"meetings/2024-03-06.md",
"meetings/2024-03-13.md",
"meetings/2024-03-20.md",
"meetings/2024-03-27.md",
"meetings/2024-04-10.md",
"meetings/2024-04-17.md",
"meetings/2024-04-24.md",
"meetings/2024-05-08.md",
"meetings/2024-05-15.md",
"meetings/2024-05-22.md",
"meetings/2024-05-29.md",
"meetings/2024-06-05.md",
"meetings/2024-06-19.md",
"meetings/2024-06-26.md",
"meetings/2024-07-03.md",
"meetings/2024-07-10.md",
"meetings/2024-07-17.md",
"meetings/2024-07-24.md",
"meetings/2024-07-31.md",
"meetings/2024-08-14.md",
"meetings/2024-08-21.md",
"meetings/2024-09-04.md",
"meetings/2024-09-11.md",
"meetings/2024-09-18.md",
"meetings/2024-10-02.md",
"meetings/2024-10-16.md",
"meetings/2024-10-23.md",
"meetings/2024-10-30.md",
"meetings/2024-11-13.md",
"meetings/2024-11-20.md",
"meetings/2024-12-04.md",
"meetings/2024-12-11.md",
"meetings/2024-12-18.md",
"meetings/2025-01-08.md",
"meetings/2025-01-22.md",
"meetings/2025-01-29.md",
"meetings/2025-02-05.md",
"meetings/2025-02-12.md",
"meetings/2025-03-05.md",
"meetings/2025-03-19.md",
"meetings/2025-04-09.md",
"meetings/2025-04-16.md",
"meetings/2025-04-23.md",
"meetings/2025-04-30.md",
"meetings/2025-05-07.md",
"meetings/2025-05-28.md",
"meetings/2025-06-11.md",
"meetings/2025-06-18.md",
"meetings/2025-06-25.md",
"meetings/2025-07-02.md",
"meetings/2025-07-16.md",
"meetings/2025-07-23.md",
"meetings/2025-07-30.md",
"meetings/2025-08-06.md",
"meetings/2025-10-15.md",
"meetings/2026-01-07.md",
"meetings/2026-01-28.md",
"meetings/2026-02-11.md",
"meetings/2026-02-18.md",
"meetings/2026-03-04.md",
"meetings/2026-03-18.md",
"meetings/2026-03-25.md",
"meetings/2026-04-01.md",
"meetings/2026-05-06.md",
"meetings/gen-meeting.sh",
"meetings/io.js/2014-10-09.md",
"meetings/io.js/2014-10-15.md",
"meetings/io.js/2014-10-29.md",
"meetings/io.js/2014-12-10.md",
"meetings/io.js/2014-12-17.md",
"meetings/io.js/2014-12-30.md",
"meetings/io.js/2015-01-07.md",
"meetings/io.js/2015-01-13.md",
"meetings/io.js/2015-01-21.md",
"meetings/io.js/2015-01-28.md",
"meetings/io.js/2015-02-04.md",
"meetings/io.js/2015-02-18.md",
"meetings/io.js/2015-03-04.md",
"meetings/io.js/2015-03-18.md",
"meetings/io.js/2015-04-01.md",
"meetings/io.js/2015-04-08.md",
"meetings/io.js/2015-04-15.md",
"meetings/io.js/2015-04-22.md",
"meetings/io.js/2015-04-29.md",
"meetings/io.js/2015-05-13.md",
"meetings/node.js/2014-12-10.md",
"meetings/node.js/2014-12-16.md",
"meetings/node.js/2014-12-18.md",
"meetings/node.js/2015-01-15.md",
"meetings/node.js/2015-01-22.md",
"meetings/node.js/2015-01-29.md",
"meetings/node.js/2015-02-05.md",
"meetings/node.js/2015-02-09.md",
"meetings/node.js/2015-02-19.md",
"meetings/node.js/2015-02-26.md",
"meetings/node.js/2015-03-05.md",
"meetings/node.js/2015-03-12.md",
"meetings/node.js/2015-03-19.md",
"meetings/node.js/2015-03-26.md",
"meetings/node.js/2015-04-09.md",
"meetings/node.js/2015-04-16.md",
"meetings/node.js/2015-04-24.md",
"meetings/node.js/2015-04-30.md",
"meetings/node.js/2015-05-07.md",
"meetings/node.js/2015-05-21.md",
"meetings/node.js/2015-06-04.md",
"package-lock.json",
"package.json",
"surveys/2020 Node.js Contributors Survey Results.pdf",
"surveys/promise-rejections/raw-data.xlsx",
"surveys/promise-rejections/survey.md",
"votes/2021-09-29-0.json",
"votes/2021-10-19-0.json",
"votes/2022-01-10-0.json",
"votes/2022-02-21-0.json",
"votes/2022-04-11-0.json",
"votes/2022-04-11-1.json",
"votes/2022-05-11-0.json",
"votes/2022-05-18-0.json",
"votes/2022-07-06-0.json",
"votes/2022-07-20-0.json",
"votes/2022-08-31-0.json",
"votes/2022-08-31-1.json",
"votes/2022-09-15-0.json",
"votes/2022-11-30-0.json",
"votes/2022-11-30-1.json",
"votes/2023-03-26-0.json",
"votes/2024-05-07-0.json",
"votes/2024-06-25-0.json",
"votes/2024-09-30-0.json",
"votes/2025-03-19-0.json",
"votes/2025-08-01-0.json",
"votes/README.md",
"votes/initiateNewVote/README.md",
"votes/initiateNewVote/_EDIT_ME.yml",
"votes/initiateNewVote/_generateNewVotePR.mjs",
"votes/initiateNewVote/decryptPrivateKeyAndCloseVote.mjs",
"votes/initiateNewVote/extractInfoFromReadme.mjs",
"votes/initiateNewVote/generateNewVote.mjs",
"votes/initiateNewVote/generateNewVotePR.mjs",
"votes/initiateNewVote/getVoteStatus.mjs"
],
"deletedFiles": []
},
"reason": "This commit touches more than one file."
},
{
"commitInfo": {
"sha": "79098bcd7f659e960424b357ad22f88f08a34848",
"signatureStatus": "E",
"author": "Matteo Collina <matteo.collina@gmail.com>",
"files": [
"votes/strip-private-modules/mcollina.json"
],
"deletedFiles": []
},
"reason": "A more recent vote commit from this author has already been counted."
}
]Footnotes
|
Node.js refuses to strip types from TypeScript files under
node_modulesand throws
ERR_UNSUPPORTED_NODE_MODULES_TYPE_STRIPPING. This keepsuncompiled TypeScript from becoming the entry point of packages published
to a registry.
nodejs/node#63869 adds
--experimental-strip-private-modules. With the flag, a TypeScript file undernode_modulescan be type stripped only if every package enclosing it in thenode_moduleschain has"private": truein its rootpackage.json. Nestedpackage.jsonfiles are ignored, and a non-private package anywhere in thechain (for example, a published package that bundles a private one) refuses
stripping. npm-compatible clients refuse to publish a
"private": truepackage. The intended use case is workspace packages that are copied rather
than symlinked into
node_modules, such aspnpm deployoutput, Dockerbuild contexts and vendored code.
If the first option wins, the request for changes is dismissed and the pull
request lands once it has passed CI. If the second option wins, the pull
request is closed.
Vote instructions:
To close the vote, at least 3 secret holder(s)1 must run the following command:
git node vote https://github.com/nodejs/TSC/pull/1900 --decrypt-key-part --post-comment/cc @nodejs/tsc
Current estimated participation: 88.89%
Footnotes
secret holders are folks who have access to the private key associated with a public key on hkps://keys.openpgp.org that references an email address listed on the TSC voting member list at the time of the opening of the vote. ↩