Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/signed-xml.ts
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,6 @@ export class SignedXml {
*/
private references: Reference[] = [];

/**
* The PrefixList each Transform of a loaded {@link Reference} carries, in transform order, which
* verification applies.
*/
private loadedPrefixLists = new WeakMap<Reference, string[][]>();

/**
Expand Down
6 changes: 4 additions & 2 deletions test/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
# Test fixtures

These fixtures in `static/` were signed by other XML-DSig implementations, so the tests that use them check interoperability rather than only this library's agreement with itself. This library can't regenerate them.
This records who signed these fixtures in `static/`. One signed by another XML-DSig implementation checks interoperability rather than only this library's agreement with itself.

- `hmac_signature.xml` and `hmac.key`: signed with the JDK's `javax.xml.crypto.dsig`.
- `inclusive_namespaces_*.xml`: signed with `client.pem` by other signers or by xml-crypto 6.3.2.
- `inclusive_namespaces_exc_c14n.xml`, `inclusive_namespaces_exc_c14n_with_comments.xml`, `inclusive_namespaces_enveloped_signature_after_exc_c14n.xml`, `inclusive_namespaces_on_second_of_two_exc_c14n.xml` and `inclusive_namespaces_after_custom_transform.xml`: signed with .NET's `System.Security.Cryptography.Xml.SignedXml` and `client.pem`.
- `inclusive_namespaces_prefix_list_with_tab.xml`: its document and reference digest come from .NET's `SignedXml`. Its `SignedInfo` was canonicalized with libxml2 and signed with openssl and `client.pem`.
- `inclusive_namespaces_in_with_comments_namespace.xml`: signed with xml-crypto 6.3.2 and `client.pem`. It checks that a signature from 6.3.2 or earlier still verifies, not interoperability. Those releases wrote a reference's `InclusiveNamespaces` under every `Transform`, in a namespace named after that Transform's `Algorithm`.
- `windows_store_signature.xml` and `windows_store_certificate.pem`: a Windows Store app receipt and the certificate that verifies it.
2 changes: 2 additions & 0 deletions test/signature-integration-tests.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,8 @@ describe("Signature integration tests", function () {
"inclusive_namespaces_exc_c14n.xml",
"inclusive_namespaces_exc_c14n_with_comments.xml",
"inclusive_namespaces_enveloped_signature_after_exc_c14n.xml",
// Signed by xml-crypto 6.3.2, which wrote InclusiveNamespaces outside the exc-c14n namespace:
// https://github.com/node-saml/xml-crypto/issues/633
"inclusive_namespaces_in_with_comments_namespace.xml",
// PrefixList="a&#x9;b" is white space delimited: https://www.w3.org/TR/xml-exc-c14n/#sec-Use
"inclusive_namespaces_prefix_list_with_tab.xml",
Expand Down
Loading