Repository navigation
hyprland-visual-editor: fix gradient borders (read noctalia-colors.conf) - #1063
Merged
Merged
Conversation
Los bordes degradados daban 'color inválido' porque el script solo buscaba noctalia-colors.lua; en configs que solo tienen .conf las variables $primary etc. quedaban literales en hl.config. Ahora detecta .lua o .conf y parsea ambos.
Contributor
|
This pull request was converted to a draft because its description is missing required Missing:
Add the items above to the description, keeping their exact wording, then mark the pull Sections that only offer context may be deleted; nothing else about this pull request was |
linux-fertxo
marked this pull request as ready for review
October 18, 2026 23:12
Contributor
|
The description now contains the required template structure. |
linux-fertxo
marked this pull request as ready for review
October 18, 2026 23:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin
linux-fertxo/hyprland-visual-editorplugin.toml)What it does
Hyprland Visual Editor (HVE): panel to apply animation, border and shader presets. This PR fixes gradient borders:
border.shonly looked fornoctalia-colors.lua, so in configs that only shipnoctalia-colors.confthe$colorvariables were never expanded andhl.configreceived a literal$primary-> invalid color when applying any gradient border.External dependencies
hyprland,bash,python(already declared inplugin.toml). Apply scripts shell out tohyprctl. No external services.Testing
Screenshots / Videos
N/A — fix to existing border presets; no visual/UI change.
Checklist
Ready-for-review requirement: Every box in this section must be checked. If any statement is not true, keep the
pull request as Draft. An explanation does not replace a required check.
idafter the/inplugin.tomlexactly.plugin.toml,README.md,thumbnail.webp, andtranslations/en.json.README.mdfollows theREADME template, documents
every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
thumbnail.webpis present and relevant; for a new plugin I created it with the thumbnail generator, and for an update I regenerated it with the generator if the visual identity or user-facing appearance changed.versionfollows semver and is bumped in this PR;plugin_apiis the oldest API level this plugin requires.understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
catalog.toml; CI generates it.Code review attestation
Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:
Ready-for-review requirement: Every attestation below must be checked.
licensedeclared inplugin.toml.