Skip to content

hyprland-visual-editor: fix gradient borders (read noctalia-colors.conf) - #1063

Merged
ItsLemmy merged 2 commits into
noctalia-dev:mainfrom
linux-fertxo:fix/border-colors-conf
Oct 19, 2026
Merged

ItsLemmy merged 2 commits into
noctalia-dev:mainfrom
linux-fertxo:fix/border-colors-conf

Conversation

@linux-fertxo

@linux-fertxo linux-fertxo commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Plugin

  • Id: linux-fertxo/hyprland-visual-editor
  • New plugin
  • Update to an existing plugin (version bumped in plugin.toml)

What it does

Hyprland Visual Editor (HVE): panel to apply animation, border and shader presets. This PR fixes gradient borders: border.sh only looked for noctalia-colors.lua, so in configs that only ship noctalia-colors.conf the $color variables were never expanded and hl.config received a literal $primary -> invalid color when applying any gradient border.

External dependencies

hyprland, bash, python (already declared in plugin.toml). Apply scripts shell out to hyprctl. No external services.

Testing

  • Tested on Niri
  • Tested on Hyprland
  • Tested on Sway
  • Tested on another compositor:
  • Noctalia version tested against: 5.3.0
  • Plugin API level: 3

Screenshots / Videos

N/A — fix to existing border presets; no visual/UI change.

Checklist

Ready-for-review requirement: Every box in this section must be checked. If any statement is not true, keep the
pull request as Draft. An explanation does not replace a required check.

  • The directory name matches the part of id after the / in plugin.toml exactly.
  • It ships plugin.toml, README.md, thumbnail.webp, and translations/en.json.
  • README.md follows the
    README template, documents
    every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
  • thumbnail.webp is present and relevant; for a new plugin I created it with the thumbnail generator, and for an update I regenerated it with the generator if the visual identity or user-facing appearance changed.
  • version follows semver and is bumped in this PR; plugin_api is the oldest API level this plugin requires.
  • Every non-English translation in this PR uses a locale supported by Noctalia core, and I can read, write, and
    understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
  • I did not edit catalog.toml; CI generates it.
  • This PR touches exactly one plugin directory.

Code review attestation

Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:
Ready-for-review requirement: Every attestation below must be checked.

  • The code is readable and not obfuscated, minified, or generated.
  • It does not download and execute remote code.
  • Every network call, filesystem write, and spawned process is something the description above accounts for.
  • I have the right to publish this code under the license declared in plugin.toml.

Los bordes degradados daban 'color inválido' porque el script solo buscaba
noctalia-colors.lua; en configs que solo tienen .conf las variables $primary
etc. quedaban literales en hl.config. Ahora detecta .lua o .conf y parsea ambos.
@github-actions
github-actions Bot marked this pull request as draft October 18, 2026 23:10
@github-actions

Copy link
Copy Markdown
Contributor

This pull request was converted to a draft because its description is missing required
parts of the pull request template.

Missing:

  • the template marker line <!-- noctalia-pr-template:v1 -->
  • the ## Plugin heading
  • the ## What it does heading
  • the ## External dependencies heading
  • the ## Testing heading
  • the ## Screenshots / Videos heading
  • the ## Checklist heading
  • the ## Code review attestation heading
  • the - **Id:** field
  • the - **Noctalia version tested against:** field
  • the - **Plugin API level:** field
  • the checklist entry: New plugin
  • the checklist entry: Update to an existing plugin (version bumped in plugin.toml)
  • the checklist entry: Tested on Niri
  • the checklist entry: Tested on Hyprland
  • the checklist entry: Tested on Sway
  • the checklist entry: Tested on another compositor:
  • the checklist entry: The directory name matches the part of id after the / in plugin.toml exactly.
  • the checklist entry: It ships plugin.toml, README.md, thumbnail.webp, and translations/en.json.
  • the checklist entry: README.md follows the README template, documents every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
  • the checklist entry: thumbnail.webp is present and relevant; for a new plugin I created it with the thumbnail generator, and for an update I regenerated it with the generator if the visual identity or user-facing appearance changed.
  • the checklist entry: version follows semver and is bumped in this PR; plugin_api is the oldest API level this plugin requires.
  • the checklist entry: Every non-English translation in this PR uses a locale supported by Noctalia core, and I can read, write, and understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
  • the checklist entry: I did not edit catalog.toml; CI generates it.
  • the checklist entry: This PR touches exactly one plugin directory.
  • the checklist entry: The code is readable and not obfuscated, minified, or generated.
  • the checklist entry: It does not download and execute remote code.
  • the checklist entry: Every network call, filesystem write, and spawned process is something the description above accounts for.
  • the checklist entry: I have the right to publish this code under the license declared in plugin.toml.
  • exactly one checked plugin type: New plugin or Update to an existing plugin
  • at least one checked compositor testing entry

Add the items above to the description, keeping their exact wording, then mark the pull
request ready for review. Draft pull requests may leave boxes unchecked. Before a pull
request is ready for review, exactly one plugin type, at least one tested compositor, and
every item under Checklist and Code review attestation must be checked.

Sections that only offer context may be deleted; nothing else about this pull request was
changed.

@linux-fertxo
linux-fertxo marked this pull request as ready for review October 18, 2026 23:12
@github-actions
github-actions Bot marked this pull request as draft October 18, 2026 23:12
@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

The description now contains the required template structure.

@linux-fertxo
linux-fertxo marked this pull request as ready for review October 18, 2026 23:13
@ItsLemmy
ItsLemmy merged commit 5571c5b into noctalia-dev:main Oct 19, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants