Skip to content

[stable35] feat: add %r placeholder for the approval requester - #537

Merged
benjaminfrueh merged 1 commit into
stable35from
backport/534/stable35
Oct 19, 2026
Merged

benjaminfrueh merged 1 commit into
stable35from
backport/534/stable35

Conversation

@backportbot

@backportbot backportbot Bot commented Oct 19, 2026

Copy link
Copy Markdown

Backport of PR #534

When a flow reacts to a tag assignment of the approval app, the actor
placeholder %a resolves to the approver on approval and rejection,
while scripts typically need to act for the user who requested the
approval (e.g. move the file into their space).

The approval app emits an ApprovalStateChangedEvent carrying the
requester right before changing its tags. The new listener stores it
in the request-scoped RequesterContext, so it is substituted when the
workflow engine reacts to the tag change within the same request. When
no requester is known, the command is not executed and a warning is
logged, consistent with the %n placeholder.

Requires the approval app to emit the event, see
#363

Assisted-by: ClaudeCode:kimi-k3
Signed-off-by: xyonium <shark_xc@hotmail.com>
@benjaminfrueh
benjaminfrueh merged commit 4b7960f into stable35 Oct 19, 2026
13 checks passed
@benjaminfrueh
benjaminfrueh deleted the backport/534/stable35 branch October 19, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants