Repository navigation
check permission - #9444
Merged
Merged
check permission#9444
Conversation
Signed-off-by: samin-z <samin.zavarkesh@gmail.com>
samin-z
requested review from
max-nextcloud,
mejo- and
silverkszlo
as code owners
October 21, 2026 14:39
mejo-
reviewed
Oct 21, 2026
| } | ||
|
|
||
| foreach ($nodes as $node) { | ||
| if (($node->getPermissions() & Constants::PERMISSION_UPDATE) === Constants::PERMISSION_UPDATE) { |
Member
There was a problem hiding this comment.
Why not use the helper from FileService here?
Contributor
Author
There was a problem hiding this comment.
the 'isReadOnly' checks the update permission and also blocks the file when it is locked, tag only needs the update permission
mejo-
approved these changes
Oct 22, 2026
| } | ||
|
|
||
| foreach ($nodes as $node) { | ||
| if (($node->getPermissions() & Constants::PERMISSION_UPDATE) === Constants::PERMISSION_UPDATE) { |
Member
|
/backport to stable35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.