Skip to content

fix(session): skip session lookup without session params - #9436

Open
mejo- wants to merge 1 commit into
mainfrom
fix/attachments_without_session
Open

mejo- wants to merge 1 commit into
mainfrom
fix/attachments_without_session

Conversation

@mejo-

@mejo- mejo- commented Oct 20, 2026

Copy link
Copy Markdown
Member

A missing documentId was cast to '' and bound against the bigint document_id column. PostgreSQL rejects that (SQLSTATE 22P02), so session-less attachment requests (e.g. read-only viewers) failed with 500 instead of falling back to user/share token auth.

Regressed with 2041dfd (snowflake document ids).

Fixes: #9415
Fixes: nextcloud/collectives#2884

Assisted-by: ClaudeCode:claude-opus-5-5

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

@mejo- mejo- self-assigned this Oct 20, 2026
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Oct 20, 2026
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Oct 20, 2026
@mejo-

mejo- commented Oct 20, 2026

Copy link
Copy Markdown
Member Author

/backport to stable35

A missing documentId was cast to '' and bound against the bigint
document_id column. PostgreSQL rejects that (SQLSTATE 22P02), so
session-less attachment requests (e.g. read-only viewers) failed with
500 instead of falling back to user/share token auth.

Regressed with 2041dfd (snowflake document ids).

Fixes: #9415
Fixes: nextcloud/collectives#2884

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: ClaudeCode:claude-opus-5-5
@mejo-
mejo- force-pushed the fix/attachments_without_session branch from c545b33 to eded378 Compare October 20, 2026 15:55

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 👀 In review

2 participants