Repository navigation
chore: Explicitly wait for participant loading to finish - #2769
Merged
Merged
Conversation
Signed-off-by: Marcel M眉ller <marcel-mueller@gmx.de>
SystemKeeper
force-pushed
the
chore/noid/reduce-leave-room-test-flakiness
branch
from
October 18, 2026 12:55
48f994b to
73df8af
Compare
Signed-off-by: Marcel M眉ller <marcel-mueller@gmx.de>
Ivansss
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although we have a scrollTo nowadays, it seems the participant loading can still push the leave button down. So let's try to wait until the spinner disappears explictily.
Second commit fixes the retry after already joined - we changed the label recently of the alert, therefore it was never found. Now we check the leave button directly.
馃 AI (if applicable)