Repository navigation
test: use the tink version shipped via UnifiedPush - #6920
Merged
AndyScherzinger merged 2 commits intoOct 17, 2026
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
📱 QA build
The QA build installs alongside a released Nextcloud app, so you can keep Downloading the file requires a GitHub account, so open this link on the |
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
AndyScherzinger
force-pushed
the
renovate/com.google.crypto.tink-tink-1.x
branch
from
October 17, 2026 15:23
4dec1dd to
21221a3
Compare
WebPushEncryptionTest checks the WebPush crypto that the app gets from tink, pulled in by org.unifiedpush.android:connector (runtime scope). Pinning a newer tink for tests only made them run against a different version than the app ships. Declare the test dependency without a version, so consistent resolution aligns it with the app's runtime classpath, and drop the now unused 1.24.0 verification entry. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally Renovate's bump of the test-only
com.google.crypto.tink:tinkdependency from 1.23.0 to 1.24.0. Reworked to keep the unit tests on the tink version the app actually ships.The app does not depend on tink directly. It ships tink 1.23.0 transitively via
org.unifiedpush.android:connector(runtime scope), which uses it for WebPush encryption. The explicittestImplementation("com.google.crypto.tink:tink:x.y.z")only exists soWebPushEncryptionTestcan compile against it, so pinning a newer version made the test check a different tink than the one in the APK.testImplementation("com.google.crypto.tink:tink")is now declared without a version. AGP's consistent resolution aligns it with the app runtime classpath, so the tests resolve exactly the tink UnifiedPush brings in (1.23.0 today) and follow it automatically when the connector updates.verification-metadata.xml.Verified: unit test compile and runtime classpaths for gplay and generic resolve tink 1.23.0, and
WebPushEncryptionTestpasses (3/3) on both flavors.🖼️ Screenshots
🚧 TODO
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)