fix(avatar): decode and save the remote avatar off the main thread

[ToteMeiSter]

PickImage.handleAvatar decoded the thumbnail stream and wrote the PNG
inside the Retrofit callback, which runs on the main thread. Do both in
the activity's lifecycleScope on Dispatchers.IO and launch the picker
back on the main thread.

🤖 Generated with Claude Code

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 05f7ea4a-1006-4404-86d4-ba0e3c9abb3a

📥 Commits

Reviewing files that changed from the base of the PR and between a0d9a78 and ca2a708.

📒 Files selected for processing: 1

• app/src/test/java/com/nextcloud/talk/utils/PickImageTest.kt

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

📝 Walkthrough

PickImage now requires a ComponentActivity. Avatar responses are decoded and saved as PNG on Dispatchers.IO. Successful saves open the local image picker. Decode, save, and download failures are logged and show a long error toast. Robolectric tests cover missing and invalid response bodies, write failures, directory targets, valid PNG saves, and response-body closure when the scope is cancelled.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to ca2a7

Remote-avatar decoding and PNG writing now run off the main thread before the picker opens. Existing callers meet the updated activity requirement, and no actionable merge-blocking risk remains in the reviewed changes.

Pre-merge checks: 3 · 2

Failed checks: 2 warnings

Check name	Status	Explanation	Resolution
Description check		The description explains the main code change and identifies AI assistance, but it omits the required Screenshots, TODO, and Checklist sections from the repository template.	Add the required template sections: Screenshots, TODO, and Checklist. Complete the checklist items or mark them as not needed, including tests, capability, backport, milestone, and PR title checks.
Docstring Coverage		Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 14 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes moving remote avatar decoding and saving off the main thread.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[rapterjet2004]

Thanks, moving the decode and the PNG write off the main thread looks right, and returning instead of crashing on response.body()!! is an improvement.

One change before this goes in: failures are now completely silent. An error response (null body), a thumbnail that doesn't decode, a failed PNG write, and onFailure (still // unused atm) all end with nothing happening. From the user's side, they pick a file and nothing happens. Please show an error to the user in these cases, e.g. a toast with R.string.nc_common_error_sorry on the main thread, and log the cause.

Small optional nit: the response body is never closed. Reading it inside body.use { BitmapFactory.decodeStream(it.byteStream()) } would fix that (pre-existing).

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 8916c517-e56d-446f-ae75-e6ba65c9c75b

📥 Commits

Reviewing files that changed from the base of the PR and between 976034c and 8e4c6f9.

📒 Files selected for processing (2)

• app/src/main/java/com/nextcloud/talk/utils/PickImage.kt
• app/src/test/java/com/nextcloud/talk/utils/PickImageTest.kt

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

[ToteMeiSter]

Thanks for the review. Pushed 8e4c6f9 and a0d9a78:

• All four failure paths (no body, thumbnail that doesn't decode, failed PNG write incl. Bitmap.compress returning false, and onFailure) now log the cause and show a R.string.nc_common_error_sorry toast on the main thread.
• The response body is closed via body?.use { … }, and also when the activity is already destroyed and the coroutine never starts (a0d9a78).
• The decode/save part is extracted into decodeAvatarToFile and covered by PickImageTest.

[rapterjet2004]

Thanks, all failure paths now tell the user, and launchClosing covering the case where the activity is destroyed before the coroutine starts is a nice catch. Tiny optional nit: decodeAvatarToFile logs with a hardcoded "PickImage" tag instead of a shared TAG constant.

[ToteMeiSter]

Thanks! Follow-up for the TAG nit: #6912.