Repository navigation
ci(lint): lower the tracked lint baseline to the current count - #6850
Merged
Merged
Conversation
The tracked baseline still claims 18 errors, while lint now reports 15 for the same 138 warnings. lint-up.rb compares each run against this file and only rewrites it when a count drops, so a baseline left above the real figure lets three errors come back without anything failing. Assisted-by: Claude Code:claude-opus-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 23 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Contributor
📱 QA build
The QA build installs alongside a released Nextcloud app, so you can keep Downloading the file requires a GitHub account, so open this link on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/analysis/lint-results.txtstill records 18 errors, while lint now reports 15 against the same 138 warnings — see the Codacy comment on #6749.This matters beyond bookkeeping.
scripts/analysis/lint-up.rbreads the count from this file, compares each run against it, and only rewrites it when the count has dropped. A baseline sitting above the real figure is slack: three errors can come back before anything fails, and the next genuine reduction is measured from the wrong starting point.Only the number changes; the file keeps its generated header and its format, so the script's own write-back on the next reduction looks exactly the same.
🖼️ Screenshots
No user-visible change.
🚧 TODO
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)