Skip to content

fix(views): return column IDs from getColumnsArray() - #3083

Open
foolfitz wants to merge 1 commit into
nextcloud:mainfrom
foolfitz:fix/view-columns-array
Open

foolfitz wants to merge 1 commit into
nextcloud:mainfrom
foolfitz:fix/view-columns-array

Conversation

@foolfitz

Copy link
Copy Markdown
Contributor

Fixes #3078

Use getId() instead of array_column() to read column IDs.
Keep IDs sorted by order and add unit tests.

Assisted-by: ClaudeCode:claude-opus-5-5

馃弫 Checklist

  • 鉀戯笍 Tests (unit and/or integration) are included or not needed
  • 馃敊 Backport requests are created or not needed: /backport to stableX.X
  • 馃搮 Milestone is set
  • 馃尭 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

馃 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@blizzz blizzz added bug Something isn't working 3. to review Waiting for reviews labels Oct 14, 2026
@blizzz

blizzz commented Oct 14, 2026

Copy link
Copy Markdown
Member

In the mean time another PR was merged that also introduced tests/unit/Db/ViewTest.php. Please adapt.

@blizzz blizzz added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 14, 2026
Use getId() instead of array_column() to read column IDs.
Keep IDs sorted by order and add unit tests.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: foolfitz <foolfitz@gmail.com>
@foolfitz
foolfitz force-pushed the fix/view-columns-array branch from b63babe to f2e91e9 Compare October 15, 2026 03:54
@foolfitz

Copy link
Copy Markdown
Contributor Author

Thanks for the approval, @blizzz! I've rebased onto main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress AI assisted bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

View API returns empty columns even when the view has columns

2 participants