Skip to content

[stable34] fix: secure view deleted tags - #6224

Merged
elzody merged 5 commits into
stable34from
backport/6220/stable34
Oct 23, 2026
Merged

elzody merged 5 commits into
stable34from
backport/6220/stable34

Conversation

@backportbot

@backportbot backportbot Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Backport of #6220

Warning, This backport's changes differ from the original and might be incomplete 鈿狅笍

Todo

  • Review and resolve any conflicts
  • Review and verify the backported changes
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
backportbot Bot requested review from elzody and juliusknorr October 23, 2026 18:51
@backportbot backportbot Bot added the 3. to review Ready to be reviewed label Oct 23, 2026
@elzody
elzody force-pushed the backport/6220/stable34 branch from d08d2db to 1b7b52e Compare October 23, 2026 19:18
@elzody
elzody marked this pull request as ready for review October 23, 2026 19:18
getAppValueArray() passed an empty array as the default, which IConfig
returns verbatim for an unset key and explode() then rejects.

Assisted-by: ClaudeCode:claude-opus-5[1m]
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
The keys holding the secure view tag ids were listed in several places.

Assisted-by: ClaudeCode:claude-opus-5[1m]
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
Tag ids without a matching system tag are dropped before they reach the
tag picker, which cannot resolve them and fails to render.

Assisted-by: ClaudeCode:claude-opus-5[1m]
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
Assisted-by: ClaudeCode:claude-opus-5[1m]
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
Assisted-by: ClaudeCode:claude-opus-5[1m]
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
@elzody
elzody force-pushed the backport/6220/stable34 branch from 1b7b52e to 4d719f9 Compare October 23, 2026 23:07
@elzody
elzody merged commit 1e200e9 into stable34 Oct 23, 2026
67 of 71 checks passed
@elzody
elzody deleted the backport/6220/stable34 branch October 23, 2026 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant