Repository navigation
fix(auto-logout): Send heartbeats while editing instead of while idle - #6197
Open
DerDreschner wants to merge 1 commit into
Open
DerDreschner wants to merge 1 commit into
DerDreschner wants to merge 1 commit into
Conversation
Author
|
Failed static analysis is unrelated to my changes. |
With `session_keepalive` disabled, the heartbeat was only sent when the stored last activity was older then half the session lifetime. While the user kept editing, the activity was refreshed every 10 seconds, so no heartbeat was sent and the session expired mid-edit. Once idle, a heartbeat was sent on every check and kept the session alive. Send at most one heartbeat per interval, and only for interactions Collabora reported since the last one. Unregister the handler when the document is closed, so closed documents stop sending heartbeats, and keep reporting the activity to core when the browser storage is not available. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
DerDreschner
force-pushed
the
fix/change-auto-logout-handling
branch
from
October 16, 2026 18:25
fa1eecb to
e90c8c1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The initial implementation from #3224 contained a bug: With
session_keepalivedisabled, the heartbeat was only sent when the stored last activity was older then half the session lifetime. While the user kept editing, the activity was refreshed every 10 seconds, so no heartbeat was sent and the session expired mid-edit. Once idle, a heartbeat was sent on every check and kept the session alive.This is being fixed with this PR by sending at most one heartbeat per interval and only for interactions Collabora reported since the last one. The handler is also unregistered when the document is closed, so closed documents stop sending heartbeats.
Checklist
AI (if applicable)